This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Simplify adding new translation language pairs #171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`train_generator` is now a method (not a property returning a function) and WMTProblem subclasses implement it directly (not via one-purpose functions)
lukaszkaiser
suggested changes
Jul 20, 2017
| @property | ||
| def train_generator(self): | ||
| """Generator; takes tmp_dir, is_training, possibly targeted_vocab_size.""" | ||
| def train_generator(self, tmp_dir, is_training): |
Contributor
There was a problem hiding this comment.
Unluckily these arguments now include data_dir, this will need updating. Also, they are different for character models, but it could be just an empty arg (_). Thanks for making this nicer!
Contributor
Author
|
New attempt: #181 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
train_generatoris now a method (not a property returning a function)and WMTProblem subclasses implement it directly (not via one-purpose functions)
vocab_nameproperty, so e.g.tokens.vocab-en-cs.32768is used instead oftokens.vocab.32768if only English+Czech datasets were used