Skip to content
This repository was archived by the owner on Jul 7, 2023. It is now read-only.

Conversation

@rsepassi
Copy link
Contributor

@rsepassi rsepassi commented Aug 4, 2017

Saying I can't auto-merge. Let's hold off on merging. Investigating...

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Ryan Sepassi and others added 12 commits August 4, 2017 16:11
PiperOrigin-RevId: 164081124
PiperOrigin-RevId: 164201984
…model_fn_body_sharded. Also updated inline doc.

PiperOrigin-RevId: 164305140
…urrent one was giving 0 losses indicating that it was peeking into the future. The way the attention bias was being added also seemed wrong. Renamed unmasked_local_attention_1d to local_attention_1d. The user can specify local_attention_1d if they want to look left and right of the query block.

PiperOrigin-RevId: 164312109
PiperOrigin-RevId: 164321289
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@rsepassi
Copy link
Contributor Author

rsepassi commented Aug 4, 2017

Ok, looks good now.

Copy link
Contributor

@lukaszkaiser lukaszkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukaszkaiser lukaszkaiser merged commit 2758f5b into tensorflow:master Aug 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants