No edges appear in the graph explorer for Chrome 62. #425
Assignees
Labels
Comments
chihuahua
added a commit
that referenced
this issue
Aug 27, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes #425.
chihuahua
added a commit
that referenced
this issue
Aug 30, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes #425.
jart
pushed a commit
to jart/tensorboard
that referenced
this issue
Sep 6, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes tensorflow#425.
jart
pushed a commit
that referenced
this issue
Sep 6, 2017
In SVG 2, getPathSegAtLength (which the graph explorer depends on as part of rendering edges), is deprecated. This means that the graph explorer would render with no edges in Chrome 62 (current in the dev channel) and would thus be very much broken in Chrome 62. This commit pre-empts that change by implementing the functionality of getPathSegAtLength in the graph explorer so that the explorer still works in Chrome 62. I do not see alternative ways of implementing this functionality using the native pathLength property + getTotalLength() and getPointAtLength() methods still provided by the SVG API. After this change goes in, we should quickly release a new pypi package and internal version of TensorBoard so that the graph explorer is not broken for users of Chrome 62. Fixes #425.
|
so what's the solution? |
|
I fixed this problem in #434! Upgrade to the latest tensorboard. Thanks! |
|
hi @chihuahua, is there any way to upgrade tensorboard while not upgrading tensorflow? |
|
It might work if you pip install tb-nightly |
|
Ah yeah! Per @jart, tb-nightly gives you bleeding edge features of TensorBoard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The problem is that Chrome 62 no longer supports the native
getPathSegAtLengthmethod. SVG 2 dropped the method. We should instead make use ofgetTotalLength()andgetPointAtLength()on theSVGGeometryElementobject.This issue must be fixed quickly, and then we should release a new pypi package as well as internal version. Otherwise, once Chrome 62 enters stable, no data flow edges will appear in the graph explorer for users (the graph would be very much broken). Chrome 62 has already entered the dev channel.
The text was updated successfully, but these errors were encountered: