Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: data-loader now responds to loadKey changes #1500

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@stephanwlee
Copy link
Collaborator

stephanwlee commented Oct 8, 2018

Please refer to #1499 for details.
The observer to the loadKey change was not triggered even when it
changed. Weirdly, the complex observer for dataToLoad was triggering
fine.

Due to the issue, the line-chart appeared stale even when its tag/run
pair has changed.

FIX: data-loader now responds to loadKey changes
Please refer to #1499 for details.
The observer to the `loadKey` change was not triggered even when it
changed. Weirdly, the complex observer for `dataToLoad` was triggering
fine.

Due to the issue, the line-chart appeared stale even when its tag/run
pair has changed.

@stephanwlee stephanwlee requested a review from nfelt Oct 8, 2018

@nfelt

nfelt approved these changes Oct 10, 2018

@stephanwlee stephanwlee merged commit 99a75c3 into tensorflow:master Oct 10, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stephanwlee stephanwlee deleted the stephanwlee:fix2 branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.