scalar: fix tiny chart #2605
Merged
scalar: fix tiny chart #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates `active` prop to a template of a tf-category-paginated-view when the category pane is collapsed/expanded. It also updates the `active` when a component is no longer mounted onto the DOM. The change does not contain any redraw logic but it magically works because the DataLoaderBehavior, when active changes to active, fetches data point for ones that are not in cache and then triggers rerender. This flow of logic is indirect and thus can be made to be more direct but that can cause too many "redraw" call which can be quite expensive (scales poorly with # of runs).
wchargin
reviewed
Aug 30, 2019
| @@ -156,7 +156,7 @@ <h3>No scalar data was found.</h3> | |||
| > | |||
| <template> | |||
| <tf-scalar-card | |||
| active="[[active]" | |||
| active="[[active]]" | |||
There was a problem hiding this comment.
…was this just like active="true" always?
wchargin
approved these changes
Aug 30, 2019
wchargin
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
activeprop to a template of atf-category-paginated-view when the category pane is collapsed/expanded.
It also updates the
activewhen a component is no longer mounted ontothe DOM.
The change does not contain any redraw logic but it magically works
because the DataLoaderBehavior, when active changes to active, fetches
data point for ones that are not in cache and then triggers rerender.
This flow of logic is indirect and thus can be made to be more direct
but that can cause too many "redraw" call which can be quite expensive
(scales poorly with # of runs).
Related to #2595.