Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc moves for TF2 #2718

Merged
merged 7 commits into from Oct 3, 2019

Conversation

@lamberta
Copy link
Member

commented Oct 2, 2019

Move files around for TF2.
Redirects in cl/272527747

staged: go/tfo-stage/tensorboard

WANT_LGTM=GalOshri

lamberta added 6 commits Oct 2, 2019
@googlebot googlebot added the cla: yes label Oct 2, 2019
@review-notebook-app

This comment has been minimized.

Copy link

commented Oct 2, 2019

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@lamberta

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

In this PR there's a "TF 1" tab that links off to GitHub for TF1 docs (and are not imported into tensorflow.org), this is what we're doing for TF Core: https://www.tensorflow.org/guide

Let me know if you do not want the TF1 tab.

@stephanwlee stephanwlee requested a review from nfelt Oct 3, 2019
Copy link
Collaborator

left a comment

It looks good to me but I think Nick should do one sanity pass.

@lamberta

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Thanks. Also chatted with @GalOshri and will make a few nav changes

@stephanwlee stephanwlee requested a review from GalOshri Oct 3, 2019
@nfelt
nfelt approved these changes Oct 3, 2019
Copy link
Collaborator

left a comment

Thanks!

@nfelt nfelt merged commit 36af080 into tensorflow:master Oct 3, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
@nfelt

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2019

Oops, I just saw the last comment - @lamberta were still going to make changes to the PR? I got excited and merged it but we can do a followup.

@lamberta

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@nfelt No worries, I can feel the excitement :) I'll make a follow-up

@lamberta lamberta deleted the lamberta:tf2 branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.