Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pylint to 1.8.1 #825

Merged
merged 1 commit into from Dec 16, 2017
Merged

Pin pylint to 1.8.1 #825

merged 1 commit into from Dec 16, 2017

Conversation

jart
Copy link
Contributor

@jart jart commented Dec 16, 2017

No description provided.

@jart jart requested a review from chihuahua December 16, 2017 05:42
Copy link
Member

@chihuahua chihuahua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting to the bottom of this!

@jart jart force-pushed the pylint branch 2 times, most recently from 236d5d6 to d72bdd9 Compare December 16, 2017 06:52
@jart jart changed the title Pin pylint to 1.7.4 Pin pylint to 1.8.1 Dec 16, 2017
@jart
Copy link
Contributor Author

jart commented Dec 16, 2017

I couldn't get the older versions to work. So I changed this PR to pin at the latest version of PyLint, and suppress all the things it was unhappy about. It did actually catch a couple legitimate things, like missing % format syntax. So everything should be good now.

@jart jart merged commit 9a2f3b8 into tensorflow:master Dec 16, 2017
@jart jart deleted the pylint branch December 16, 2017 08:07
nfelt pushed a commit to nfelt/tensorboard that referenced this pull request Jan 18, 2018
nfelt pushed a commit that referenced this pull request Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants