New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

there is no idct implementation in tensorflow #20188

Open
tuxzz opened this Issue Jun 21, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@tuxzz

tuxzz commented Jun 21, 2018

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
  • TensorFlow installed from (source or binary): binary
  • TensorFlow version (use command below): b'v1.8.0-0-g93bc2e2072' 1.8.0
  • Python version: 3.6.5
  • Bazel version (if compiling from source):
  • GCC/Compiler version (if compiling from source):
  • CUDA/cuDNN version: 9.0
  • GPU model and memory: GTX 780 6G
  • Exact command to reproduce: none

Describe the problem

We have tf.spectral.dct but no tf.spectral.idct.
What's wrong?

Source code / logs

None

@tensorflowbutler

This comment has been minimized.

Show comment
Hide comment
@tensorflowbutler

tensorflowbutler Jul 6, 2018

Member

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Member

tensorflowbutler commented Jul 6, 2018

Nagging Assignee @aselle: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@GeorgyZhou

This comment has been minimized.

Show comment
Hide comment
@GeorgyZhou

GeorgyZhou Jul 24, 2018

Contributor

I can try to work on this and submitted a PR later.

Contributor

GeorgyZhou commented Jul 24, 2018

I can try to work on this and submitted a PR later.

@GeorgyZhou

This comment has been minimized.

Show comment
Hide comment
@GeorgyZhou

GeorgyZhou Jul 25, 2018

Contributor

And I found that the idct is already in master. You can access the file through the link here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/spectral_ops.py#L267
What we need to do is to just push this commit into next release version. BTW please closes the issue @aselle Thanks!

Contributor

GeorgyZhou commented Jul 25, 2018

And I found that the idct is already in master. You can access the file through the link here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/ops/spectral_ops.py#L267
What we need to do is to just push this commit into next release version. BTW please closes the issue @aselle Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment