Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docstring of @tf.exports methods in tf.nest. #36186

Merged
merged 15 commits into from Feb 19, 2020
Merged

Update the docstring of @tf.exports methods in tf.nest. #36186

merged 15 commits into from Feb 19, 2020

Conversation

punndcoder28
Copy link
Contributor

@punndcoder28 punndcoder28 commented Jan 24, 2020

This PR is to resolve the issue #36146.

@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Jan 24, 2020
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@punndcoder28 punndcoder28 changed the title Update the docstring of @tf.exports methods in tf.nest #36146 Update the docstring of @tf.exports methods in tf.nest. Jan 24, 2020
@punndcoder28
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@punndcoder28
Copy link
Contributor Author

punndcoder28 commented Jan 24, 2020

@googlebot I signed it!

@punndcoder28 punndcoder28 changed the title Update the docstring of @tf.exports methods in tf.nest. Update the docstring of @tf.exports methods in tf.nest. Jan 24, 2020
@punndcoder28 punndcoder28 marked this pull request as ready for review January 24, 2020 17:48
Copy link

@mdanatg mdanatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping improve this! A couple of suggestions.

tensorflow/python/util/nest.py Outdated Show resolved Hide resolved
@rthadur rthadur self-assigned this Jan 24, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jan 24, 2020
@rthadur
Copy link
Contributor

rthadur commented Jan 24, 2020

@punndcoder28 please sign CLA

@punndcoder28
Copy link
Contributor Author

@googlebot I signed it!

@punndcoder28
Copy link
Contributor Author

@rthadur I've signed the CLA. I had made a mistake with the previous signing, I changed it and commented but the google bot is not replying.

@ashutosh1919
Copy link
Contributor

@punndcoder28 , If you are signing CLA (here) then please sign CLA for all the email IDs which you are already logged in in your browser. I faced the same problem once but I got solution after posting the question to stackoverflow here.

@punndcoder28
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@punndcoder28
Copy link
Contributor Author

@ashutosh1919 Thanks a lot!

@rthadur rthadur requested a review from mdanatg January 25, 2020 20:33
@ashutosh1919
Copy link
Contributor

this PR is to fix issue #36146. (Mentioned so that whenever someone sees that issue, he/she won't start work on that because this PR is already there on that issue).

tensorflow/python/util/nest.py Show resolved Hide resolved
tensorflow/python/util/nest.py Outdated Show resolved Hide resolved
Copy link

@mdanatg mdanatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of changes remaining.

tensorflow/python/util/nest.py Outdated Show resolved Hide resolved
tensorflow/python/util/nest.py Outdated Show resolved Hide resolved
mdanatg
mdanatg previously approved these changes Feb 11, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Feb 11, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 11, 2020
@mdanatg
Copy link

mdanatg commented Feb 11, 2020

Looks like there is a lint error - see the Details link next to the Ubuntu Sanity check above, search for do_pylint in the logs.

@punndcoder28
Copy link
Contributor Author

punndcoder28 commented Feb 12, 2020 via email

@punndcoder28
Copy link
Contributor Author

punndcoder28 commented Feb 12, 2020

I don't usually enable pylint while coding as it gives me errors even if the code is right. I will enable it on my local machine and check what the issue is.

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Feb 12, 2020
@tensorflow-bot tensorflow-bot bot removed the ready to pull PR ready for merge process label Feb 12, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Feb 12, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 12, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 12, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process stat:awaiting response Status - Awaiting response from author labels Feb 13, 2020
@tensorflow-copybara tensorflow-copybara merged commit 053680b into tensorflow:master Feb 19, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants