New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the docstring of @tf.exports methods in tf.nest. #36186
Update the docstring of @tf.exports methods in tf.nest. #36186
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@tf.exports
methods in tf.nest #36146@tf.exports
methods in tf.nest.
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@tf.exports
methods in tf.nest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping improve this! A couple of suggestions.
@punndcoder28 please sign CLA |
@googlebot I signed it! |
@rthadur I've signed the CLA. I had made a mistake with the previous signing, I changed it and commented but the google bot is not replying. |
@punndcoder28 , If you are signing CLA (here) then please sign CLA for all the email IDs which you are already logged in in your browser. I faced the same problem once but I got solution after posting the question to stackoverflow here. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@ashutosh1919 Thanks a lot! |
this PR is to fix issue #36146. (Mentioned so that whenever someone sees that issue, he/she won't start work on that because this PR is already there on that issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple of changes remaining.
Looks like there is a lint error - see the Details link next to the Ubuntu Sanity check above, search for do_pylint in the logs. |
Yes. I noticed it as soon as you approved the PR. I see how to resolve that immediately.
…Sent from my iPhone
On 12-Feb-2020, at 4:17 AM, Dan Moldovan ***@***.***> wrote:
Looks like there is a lint error - see the Details link next to the Ubuntu Sanity check above, search for do_pylint in the logs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
I don't usually enable pylint while coding as it gives me errors even if the code is right. I will enable it on my local machine and check what the issue is. |
This PR is to resolve the issue #36146.