Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add show_dtype support for plot_model, update related tests. #40601

Merged
merged 11 commits into from Jun 26, 2020
Merged

Add show_dtype support for plot_model, update related tests. #40601

merged 11 commits into from Jun 26, 2020

Conversation

jonah-kohn
Copy link
Contributor

In response to a feature request.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 19, 2020
@gbaned gbaned self-assigned this Jun 19, 2020
@gbaned gbaned added the comp:keras Keras related issues label Jun 19, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 19, 2020
@gbaned gbaned requested a review from qlzh727 June 19, 2020 04:41
qlzh727
qlzh727 requested changes Jun 19, 2020
View reviewed changes
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonah for the contribution.

tensorflow/python/keras/utils/vis_utils.py Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jun 19, 2020
jonah-kohn
jonah-kohn commented Jun 19, 2020
View reviewed changes
Copy link
Contributor Author

@jonah-kohn jonah-kohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented Scott's suggested change

tensorflow/python/keras/utils/vis_utils.py Outdated Show resolved Hide resolved
@jonah-kohn jonah-kohn requested a review from qlzh727 June 19, 2020 19:35
jonah-kohn
jonah-kohn commented Jun 19, 2020
View reviewed changes
Copy link
Contributor Author

@jonah-kohn jonah-kohn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctly access layer attributes

tensorflow/python/keras/utils/vis_utils.py Outdated Show resolved Hide resolved
qlzh727
qlzh727 previously approved these changes Jun 22, 2020
View reviewed changes
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jun 22, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 22, 2020
jonah-kohn
jonah-kohn commented Jun 22, 2020
View reviewed changes
Copy link
Contributor Author

@jonah-kohn jonah-kohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fit linter indentation requirements.

tensorflow/python/keras/utils/vis_utils_test.py Outdated Show resolved Hide resolved
tensorflow/python/keras/utils/vis_utils.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 22, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Jun 22, 2020
@jonah-kohn jonah-kohn requested a review from qlzh727 June 22, 2020 18:24
@jonah-kohn jonah-kohn requested a review from qlzh727 June 23, 2020 19:02
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jun 23, 2020
qlzh727
qlzh727 previously approved these changes Jun 23, 2020
View reviewed changes
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 23, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 23, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jun 23, 2020
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Jun 23, 2020
@gbaned gbaned requested a review from qlzh727 June 24, 2020 07:40
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jun 24, 2020
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 24, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 24, 2020
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jun 25, 2020
@tensorflow-copybara tensorflow-copybara merged commit db0cd35 into tensorflow:master Jun 26, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qlzh727 qlzh727 qlzh727 approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jonah-kohn @qlzh727 @googlebot @kokoro-team @tensorflow-copybara @gbaned