Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: incomplete description of callbacks.ModelCheckpoint's save_best_only parameter #41420

Closed
bersbersbers opened this issue Jul 15, 2020 · 3 comments
Assignees
Labels
comp:keras Keras related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:docs-bug Document issues

Comments

@bersbersbers
Copy link

URL(s) with the issue:

https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/ModelCheckpoint

Description of issue (what needs changing):

  1. mode: "{auto, min, max}" should be {auto, min, max}, I guess (minor)
  2. save_best_only: I believe the description is incomplete. With save_best_only=True, not only will "the latest best model [...] not be overwritten": but also the current model is not written at all, even if it has another filename than the "latest best model". This is kind of implied by the name of the parameter, but the description should include that, too.
@ravikyram ravikyram added comp:keras Keras related issues type:docs-bug Document issues labels Jul 17, 2020
@ravikyram ravikyram assigned gowthamkpr and unassigned ravikyram Jul 17, 2020
@gowthamkpr gowthamkpr assigned MarkDaoust and unassigned gowthamkpr Jul 17, 2020
@gowthamkpr gowthamkpr added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Jul 17, 2020
@yil532
Copy link

yil532 commented Jul 20, 2020

Hi Can I create a PR to fix this?

@yil532
Copy link

yil532 commented Jul 20, 2020

PR to fix this issue is here #41567
Please review, thank you!

@jvishnuvardhan
Copy link
Contributor

This is already fixed by #41567. Please check the updated tf-nightly page https://www.tensorflow.org/api_docs/python/tf/keras/callbacks/ModelCheckpoint?version=nightly.

I am closing this issue as this was already resolved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:keras Keras related issues stat:awaiting tensorflower Status - Awaiting response from tensorflower type:docs-bug Document issues
Projects
None yet
Development

No branches or pull requests

6 participants