Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TensorMap: Update TensorMap Gradients and Gradient Tests #41905

Closed
wants to merge 55 commits into from
Closed

TensorMap: Update TensorMap Gradients and Gradient Tests #41905

wants to merge 55 commits into from

Conversation

kttian
Copy link
Contributor

@kttian kttian commented Jul 30, 2020

Update gradients and gradient tests for the TensorMap feature to be more comprehensive.

  1. Add gradient for the erase op.
  2. Implement ZerosLike and BinaryAdd kernels, which will be used in certain gradients.
  3. Add gradient tests to cover more cases, including gradients for more function combinations, replace, erase, and non-scalar values.
    @mdanatg @saxenasaurabh @dynamicwebpaige

kttian added 30 commits June 22, 2020 16:43
@kttian
initial map ops set up
43442a2
@kttian
cc build file
b619d2c
@kttian
initial TensorMap class
fc15ab8
@kttian
build and test updates
2661230
@kttian
working absl hashable tensor
07c5adf
@kttian
tensor map tests
5d8e3a4
@kttian
TensorKey class and TensorMap tests
ce47a39
@kttian
EncodeDecode Test working
0d5104e
@kttian
build updates
9c424e4
@kttian
import guards
19632ba
@kttian
latest
15068b9
@kttian
latest
f8933ad
@kttian
working op: include variant_encode_decode.h in map_kernels.h
e0170c9
@kttian
working EmptyTensorMap op
38071c9
@kttian
working TensorMapInsert op
bed9180
@kttian
insert, lookup, erase, replace, and initial gradients
609fe79
@kttian
working gradient!
6e89b83
@kttian
clean working first gradient
fd8eb85
@kttian
cleanup
4904a46
@kttian
restore list_ops_test
8f3cbfa
@kttian
restore list_ops.py
6a57263
@kttian
most pr edits
395380e
@kttian
update map test cases for insert and erase
2191a9d
@kttian
test replace missing key fails
13e3f35
@kttian
restore list_ops_test.py
c4b16f1
@kttian
update TensorMapDeviceCopy
344c570
@kttian
minor fix
f18240b
@kttian
update tests
ae85ce5
@kttian
removed unused imports
02ca057
@kttian
add api def files
e3d5bcc
@google-ml-butler google-ml-butler bot added the size:XL CL Change Size:Extra Large label Jul 30, 2020
@kttian kttian changed the title Update TensorMap Gradients and Gradient Tests TensorMap: Update TensorMap Gradients and Gradient Tests Aug 5, 2020
@kttian kttian closed this Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdanatg mdanatg Awaiting requested review from mdanatg

@saxenasaurabh saxenasaurabh Awaiting requested review from saxenasaurabh

Assignees
No one assigned
Labels
cla: yes size:XL CL Change Size:Extra Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kttian @googlebot