Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 #44485

Closed
park-junha opened this issue Oct 31, 2020 · 80 comments
Closed

Support Python 3.9 #44485

park-junha opened this issue Oct 31, 2020 · 80 comments
Assignees
Labels
TF 2.5 Issues related to TF 2.5 type:build/install Build and install issues type:feature Feature requests

Comments

@park-junha
Copy link
Contributor

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template

System information

  • TensorFlow version (you are using): 2.3.1
  • Are you willing to contribute it (Yes/No): No (willing to do trivial patches)

Describe the feature and the current behavior/state.
TensorFlow should be supported on Python 3.9.

Will this change the current api? How? Significant changes will likely need to be made.

Who will benefit with this feature?
Anyone on Python 3.9

Any Other info.

@mihaimaruseac
Copy link
Collaborator

We have not released anything for python3.9.

Release process is as follows:

  1. Ensure all of our dependencies support python3.9 (not yet there)
  2. Ensure our code works with all these dependencies on all supported versions of python (at the moment, at least gast needs additional support work).
  3. Release nightly version supporting the new python version
  4. Release a full release.

As we are already doing the 2.4 release, python3.9 support for TF will come in 2.5 release at the earliest.

@ravikyram, @amahendrakar, @rmothukuru let's deduplicate to this issue all py39 requests/issues. I'll monitor this one and provide updates as we start adding support.

@rmothukuru
Copy link
Contributor

@mihaimaruseac,
Sure

@rmothukuru rmothukuru added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 17, 2020
@mihaimaruseac
Copy link
Collaborator

I may be wrong, but I believe this is the case:

python3.8 -m pipdeptree -p tensorflow | grep "^  -" | sed "s/  - //" | sed "s/ \[.*]//" | xargs python3.9 -m pip install

which is essentially

python3.9 -m pip install absl-py astunparse flatbuffers gast google-pasta grpcio h5py keras-preprocessing numpy opt-einsum protobuf six tensorboard tensorflow-estimator termcolor typing-extensions wheel wrapt

works fine for me. Am I missing anything?

(from #40840 (comment))

The main issue is that we also have C++ code and we need the needed dependencies to also upgrade for their C++ code. By this time, likely most are solved, so 2.5 release will have py3.9 support.

We should get py3.9 in nightly soon.

@mihaimaruseac
Copy link
Collaborator

So, all of our depdencies have a release for py3.9 but our setup.py upper bounds to versions which are below that release. We will need to increase these bounds while making sure we don't break existing usecases/tests. Will slowly happen over December.

@tensorflowbutler tensorflowbutler removed the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 27, 2020
@ShyamSundhar1411
Copy link

But tf nightly is not getting imported . I am getting ModuleNotFoundError

@mihaimaruseac mihaimaruseac pinned this issue Mar 15, 2021
@mihaimaruseac
Copy link
Collaborator

@ShyamSundhar1411 this looks like a different issue. Make sure you use the same python as the one used to do pip install. Recommendation is to use python -m pip install instead of pip install.

If the above does not fix, please open a new issue and fill in issue template and give a full description of the error you are seeing. Also, give output of both python -m pip install

@cclauss
Copy link
Contributor

cclauss commented Mar 15, 2021

Explicit is better than implicit...python3.9 -m pip install xyz

@staticdev
Copy link

@mihaimaruseac this is marked for TF 2.5 but there is no mention of it on the current release notes.

@mihaimaruseac
Copy link
Collaborator

RC0 files already contain Py3.9 wheels.

We'll update the release notes, it seems we don't always mention support for new versions of Python in there.

@cclauss
Copy link
Contributor

cclauss commented May 17, 2021

I think this is fixed now.

@Nizarazo
Copy link

Is Keras module that exists in tensorflow supported in python 3.9?

@felixdivo
Copy link

@mihaimaruseac Seems like this issue can be closed.

@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

guygurari added a commit to google/BIG-bench that referenced this issue Jul 7, 2021
TensorFlow added support for python 3.9, so this check can be removed:
tensorflow/tensorflow#44485
ajslone pushed a commit to google/BIG-bench that referenced this issue Jul 7, 2021
TensorFlow added support for python 3.9, so this check can be removed:
tensorflow/tensorflow#44485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TF 2.5 Issues related to TF 2.5 type:build/install Build and install issues type:feature Feature requests
Projects
None yet
Development

No branches or pull requests