Properly support complex in SparseTensorDenseMatMul #47355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmasaur
force-pushed
the
complex_sparse_grad
branch
2 times, most recently
from
9ac90fd to
2ee44de
Compare
charmasaur
force-pushed
the
complex_sparse_grad
branch
from
2ee44de to
0623c04
Compare
For a start the test wasn't being run. But it also had a problem where the test in the complex case was trivial (the matrices) were all zeros: it was creating `x` in `[0,1]`, then turning it into `(x+1j*x)/2` via `_maybe_complex`, and then setting all the values with magnitude below `0.8` to `0`. But even `(1+1j)/2` (the value with largest magntidue that `x` can take) only has a magnitude of about `0.7`. Fix is just to create complex numbers as `x+x*1j` instead.
Contributor
Author
|
I'm having trouble testing this locally because I can't build TF (I'm just on a little laptop :C), but CI seems to have run everything successfully at 0623c04. I don't think the test update I've made since then should be a problem, but hard to know until it runs. |
google-ml-butler
bot
added
kokoro:force-run
Contributor
Author
|
Thanks! And thanks for the review :) |
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds gradient support for complex, and fixes a bug with adjoints (#47337).
My laptop can't build, so I haven't been able to properly test this yet. Hopefully CI will do it?