Clarify behavior of array_to_img(scale=True) #47763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was confused why my images looked wrong (e.g., `apply_brightness_shift` does nothing?!). I had interpreted `scale=True` to mean "multiply by 255 to go from `[0,1]` format to `[0,255]` format". This is _not_ what it does. I've copied the more precise docs from https://github.com/keras-team/keras-preprocessing/blob/master/keras_preprocessing/image/utils.py#L271-L272 (I've also made the `x` doc more precise - it does not just accept a Numpy array; e.g. it accepts tensors)
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused why my images looked wrong (e.g.,
apply_brightness_shiftdoes nothing?!). I had interpretedscale=Trueto mean "multiply by 255 to go from[0,1]format to[0,255]format". This is not what it does. I've copied the more precise docs from https://github.com/keras-team/keras-preprocessing/blob/master/keras_preprocessing/image/utils.py#L271-L272(I've also made the
xdoc more precise - it does not just accept a Numpy array; e.g. it accepts tensors)