Skip to content

[tf.data] break down and parameterize FromSparseTensorSlicesTest #47953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
copybara-service merged 1 commit into from
Mar 23, 2021
Merged

[tf.data] break down and parameterize FromSparseTensorSlicesTest #47953

copybara-service merged 1 commit into from
Mar 23, 2021

Conversation

@kvignesh1420
Copy link
Member

@kvignesh1420 kvignesh1420 commented Mar 21, 2021

This PR refactors the FromSparseTensorSlicesTest by splitting the test into multiple parameterized tests.

Addresses point 6 in #46761 (comment).
cc: @jsimsa

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Mar 21, 2021
@google-cla google-cla bot added the cla: yes label Mar 21, 2021
@gbaned gbaned self-assigned this Mar 21, 2021
@gbaned gbaned added the comp:data tf.data related issues label Mar 21, 2021
@gbaned gbaned requested a review from jsimsa March 21, 2021 16:27
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 21, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 23, 2021
@copybara-service copybara-service bot merged commit 4763c16 into tensorflow:master Mar 23, 2021
@kvignesh1420 kvignesh1420 deleted the param-sparse-tslices branch March 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsimsa jsimsa jsimsa approved these changes

Assignees

@gbaned gbaned

Labels

cla: yes comp:data tf.data related issues ready to pull PR ready for merge process size:S CL Change Size: Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kvignesh1420 @jsimsa @kokoro-team @gbaned