[determinism] Add CPU-focused tests for fused softmax/cross-entropy ops #48688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjoy
approved these changes
Apr 25, 2021
google-ml-butler
bot
added
kokoro:force-run
duncanriach
deleted the
add-cpu-determinism-tests-for-fused-softmax-cross-entropy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This current PR is a follow-up to PR 47925 (Add softmax/cross-entropy op exceptions for GPU determinism), and specifically to this interaction between @sanjoy and myself.
This current PR adds determinism tests for the CPU implementations of
tf.softmax_cross_entropy_with_logitsandtf.sparse_softmax_cross_entropy_with_logits. When deterministic GPU implementations are added for these ops, the tests can be used to demonstrate, confirm, and ensure that the functionality is, and stays, deterministic.