[MLIR][DISC] pattern conversion from tf2mhlo: ConvertSplitOpDynamic, ConvertSliceOpDynamic #49849
Conversation
…onvertSliceOpDynamic
|
Can you add test coverage for this? |
added |
| auto loc = op.getLoc(); | ||
| auto input = op.input(); | ||
| auto begin_indices = op.begin(); | ||
| auto sizes = op.size(); |
There was a problem hiding this comment.
Please reverse auto for when the type is obvious from the immediate context and it improves readability.
(here and elsewhere)
(LG otherwise)
There was a problem hiding this comment.
(sorry I wrote this 3 weeks ago but didn't send it properly...)
There was a problem hiding this comment.
Done. BTW. If one commit fail on CI (such as "AMD ROCm -- Community CI Build"). The details link is unable to open usually. Is there any alternate method to get the failure information?
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
azazhu
force-pushed
the
feature/disc_porting_tf_to_mhlo_pat_part2
branch
from
35d5d63 to
65a0afd
Compare
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
added
kokoro:force-run
joker-eph
added
ready to pull
|
@azazhu Can you please resolve conflicts? Thanks! |
Done |
google-ml-butler
bot
added
kokoro:force-run
4 participants
We are porting our MLIR-based dynamic shape compiler to tf community (From OP def, Patttern, to Optimization pass, etc).
This is the third PR about tf2mhlo pattern conversion, which including ConvertSplitOpDynamic and ConvertSliceOpDynamic.
The rest pattern conversions we will add: