Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comma in test results in unexpected string concatenation #53636

Closed
code-review-doctor opened this issue Jan 4, 2022 · 4 comments
Closed
Assignees
Labels
comp:keras Keras related issues stat:awaiting response Status - Awaiting response from author TF 2.7 Issues related to TF 2.7.0 type:bug Bug

Comments

@code-review-doctor
Copy link
Contributor

System information.

  • Have I written custom code (as opposed to using a stock example script provided in Keras): NA
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): NA
  • TensorFlow installed from (source or binary): NA
  • TensorFlow version (use command below): NA
  • Python version: NA
  • Bazel version (if compiling from source): NA
  • GPU model and memory: NA
  • Exact command to reproduce: NA

Describe the problem.

Absent comma results in unwatned string concatenation on line 330:

x = [
'I think juice is great',
'unknown is the best language since slicedbread',
'a a a a a a a',
'matmul'
'Yaks are also quite nice',
]

So 'matmul' gets appended with 'Yaks are also quite nice' resulting in matmulYaks are also quite nice being used in the test.

Describe the current behavior.

'matmulYaks are also quite nice' is used in the test

Describe the expected behavior.

'matmul', 'Yaks are also quite nice' is used in the test

Contributing.

  • Do you want to contribute a PR? (yes/no): yes
  • Briefly describe your candidate solution(if contributing):

Add the missing comma

Standalone code to reproduce the issue.

NA

Source code / logs.

NA

@sachinprasadhs sachinprasadhs added TF 2.7 Issues related to TF 2.7.0 comp:keras Keras related issues labels Jan 4, 2022
@sachinprasadhs
Copy link
Contributor

Would you like to create a PR for the same

@sachinprasadhs
Copy link
Contributor

sachinprasadhs commented Jan 6, 2022

Could you please create the PR in github.com/keras-team/keras repo as per the above linked PR. Let us know if you need any help with that. Thanks!

@sachinprasadhs sachinprasadhs added the stat:awaiting response Status - Awaiting response from author label Jan 6, 2022
@code-review-doctor
Copy link
Contributor Author

this is now fixed upstream

@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:keras Keras related issues stat:awaiting response Status - Awaiting response from author TF 2.7 Issues related to TF 2.7.0 type:bug Bug
Projects
None yet
Development

No branches or pull requests

3 participants