Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixed in tf.custom_gradient API Document #58486

Merged

Conversation

SuryanarayanaY
Copy link
Collaborator

tf.custom_gradient documentation have the below code snippet from line nos.63 to 65 which is throwing Runtime Error:tf.gradients is not supported when eager execution is enabled. Use tf.GradientTape instead.

 x = tf.constant(100.)
 y = log1pexp(x)
 dy_dx = tf.gradients(y, x) # Will be NaN when evaluated.

The above code snippet needs to be replaced with the one attached below to avoid the runtime error in 2.X versions.

with tf.GradientTape() as tape:
  tape.watch(x)
  y=log1pexp(x)
dy_dx = tape.gradient(y, x) # Will be NaN when evaluated.

Please refer to the attached gist below for same.

tf.custom_gradient documentation have the below code snippet from line nos.63 to 65 which is throwing Runtime Error:tf.gradients is not supported when eager execution is enabled. Use tf.GradientTape instead.
 x = tf.constant(100.)
 y = log1pexp(x)
 dy_dx = tf.gradients(y, x) # Will be NaN when evaluated.

The above code snippet needs to be replaced with the one attached below to avoid the runtime error in 2.X versions.
with tf.GradientTape() as tape:
  tape.watch(x)
  y=log1pexp(x)
dy_dx = tape.gradient(y, x) # Will be NaN when evaluated.

Please refer to the attached gist below for same.
https://colab.research.google.com/gist/SuryanarayanaY/e692b30c318c42e86819bc153ab2ee77/tf_gradient.ipynb#scrollTo=YQoLZkmVgUok
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Nov 9, 2022
@google-cla
Copy link

google-cla bot commented Nov 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 9, 2022
@gbaned gbaned removed the awaiting review Pull request awaiting review label Nov 9, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 9, 2022
@gbaned gbaned added the comp:ops OPs related issues label Nov 9, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 11, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 11, 2022
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Nov 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 14, 2022
@gbaned gbaned added cla: yes kokoro:force-run Tests on submitted change labels Nov 15, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 15, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Dec 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 2, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Dec 15, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 15, 2022
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Dec 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 28, 2022
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Dec 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 28, 2022
@copybara-service copybara-service bot merged commit e6b9ef5 into tensorflow:master Dec 28, 2022
@SuryanarayanaY SuryanarayanaY deleted the tf_gradient_docstring_fix branch January 18, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:ops OPs related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants