Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneDNN] fix matmul dest memory initialization #59238

Merged
merged 1 commit into from Jan 23, 2023
Merged

[oneDNN] fix matmul dest memory initialization #59238

merged 1 commit into from Jan 23, 2023

Conversation

linlifan
Copy link
Contributor

@linlifan linlifan commented Jan 12, 2023 •
edited

matmul primitive destination memory was initialized with incorrect memory descriptor, here is a fix for potential issue.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jan 12, 2023
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jan 12, 2023
@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 12, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 12, 2023
@gbaned gbaned removed the ready to pull PR ready for merge process label Jan 12, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 12, 2023
@gbaned gbaned added the comp:mkl MKL related issues label Jan 12, 2023
@linlifan linlifan changed the title fix matmul dest memory initialization [oneDNN] fix matmul dest memory initialization Jan 18, 2023
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jan 21, 2023
penpornk
penpornk approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 21, 2023
@copybara-service copybara-service bot merged commit 8c50395 into tensorflow:master Jan 23, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review comp:mkl MKL related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@linlifan @penpornk @kokoro-team @gbaned