New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http://zlib.net/zlib-1.2.8.tar.gz no longer available #6594

Closed
ahundt opened this Issue Jan 1, 2017 · 17 comments

Comments

Projects
None yet
@ahundt

ahundt commented Jan 1, 2017

I'm attempting to install tensorflow 0.12.1 from the r0.12 branch from source.

zlib has been updated from 1.2.8 to 1.2.9 so it appears the link must be updated from:
http://zlib.net/zlib-1.2.8.tar.gz

edit: per later comments, this has been moved to http://zlib.net/fossils/zlib-1.2.8.tar.gz

one solution may be to update to:
http://zlib.net/zlib-1.2.9.tar.gz

here is the error I'm getting:

INFO: Starting clean (this may take a while). Consider using --expunge_async if the clean takes more than several minutes.
........
ERROR: /home/ahundt/src/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': Error downloading [http://zlib.net/zlib-1.2.8.tar.gz] to /home/ahundt/.cache/bazel/_bazel_ahundt/beca172f341045bf57b6baf5296669b3/external/zlib_archive/zlib-1.2.8.tar.gz: GET returned 404 Not Found and referenced by '//tensorflow/core:lib_internal'.
ERROR: /home/ahundt/src/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': Error downloading [http://zlib.net/zlib-1.2.8.tar.gz] to /home/ahundt/.cache/bazel/_bazel_ahundt/beca172f341045bf57b6baf5296669b3/external/zlib_archive/zlib-1.2.8.tar.gz: GET returned 404 Not Found and referenced by '//tensorflow/core:lib_internal'.
ERROR: Evaluation of query "deps((//tensorflow/... union @bazel_tools//tools/jdk:toolchain))" failed: errors were encountered while computing transitive closure.

In addition to the breakage fix, perhaps it would also make sense to make a change that would prevent future breakage of this sort?

@m9psy

This comment has been minimized.

Show comment
Hide comment
@m9psy

m9psy Jan 2, 2017

For those wanderers with the same problem it can be fixed changing tensorflow/tensorflow/workspace.bzl from

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/zlib-1.2.8.tar.gz",
      sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
      strip_prefix = "zlib-1.2.8",
      build_file = str(Label("//third_party:zlib.BUILD")),
)

To

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/zlib-1.2.9.tar.gz",
      sha256 = "73ab302ef31ed1e74895d2af56f52f5853f26b0370f3ef21954347acec5eaa21",
      strip_prefix = "zlib-1.2.9",
      build_file = str(Label("//third_party:zlib.BUILD")),
)

m9psy commented Jan 2, 2017

For those wanderers with the same problem it can be fixed changing tensorflow/tensorflow/workspace.bzl from

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/zlib-1.2.8.tar.gz",
      sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
      strip_prefix = "zlib-1.2.8",
      build_file = str(Label("//third_party:zlib.BUILD")),
)

To

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/zlib-1.2.9.tar.gz",
      sha256 = "73ab302ef31ed1e74895d2af56f52f5853f26b0370f3ef21954347acec5eaa21",
      strip_prefix = "zlib-1.2.9",
      build_file = str(Label("//third_party:zlib.BUILD")),
)
@seungryulchoisc

This comment has been minimized.

Show comment
Hide comment
@seungryulchoisc

seungryulchoisc Jan 2, 2017

This fix does not work for me. Instead, both zlib-1.2.8.tar.gz and zlib-1.2.9.tar.gz are moved under http://zlib.net/fossils/ So it needs to be

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/fossils/zlib-1.2.8.tar.gz",
      sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
      strip_prefix = "zlib-1.2.8",
      build_file = str(Label("//third_party:zlib.BUILD")),
)

seungryulchoisc commented Jan 2, 2017

This fix does not work for me. Instead, both zlib-1.2.8.tar.gz and zlib-1.2.9.tar.gz are moved under http://zlib.net/fossils/ So it needs to be

native.new_http_archive(
      name = "zlib_archive",
      url = "http://zlib.net/fossils/zlib-1.2.8.tar.gz",
      sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
      strip_prefix = "zlib-1.2.8",
      build_file = str(Label("//third_party:zlib.BUILD")),
)

@ahundt ahundt changed the title from http://zlib.net/zlib-1.2.8.tar.gz no longer available, needs http://zlib.net/zlib-1.2.9.tar.gz to http://zlib.net/zlib-1.2.8.tar.gz no longer available Jan 2, 2017

@ahundt

This comment has been minimized.

Show comment
Hide comment
@ahundt

ahundt Jan 2, 2017

Suggested options for a permanent fix:

  1. The github release could be used for the relevant files, which @madler of zlib himself conveniently provides https://github.com/madler/zlib/releases, perhaps releases here can be consistently expected in the future?
  2. propose to zlib that they have a permalink available on zlib.net (or find/switch to it if it already exists)
  3. As the stewards of tensorflow, I assume google has, and they may want to use their own googley options and may want to use them. :-)
  4. Enable or make use of existing support for check more than one url location for redundancy which should be safe if the hash is correct and secure (i.e. provide both the normal http://zlib.net/zlib-1.2.8.tar.gz and fossils http://zlib.net/fossils/zlib-1.2.8.tar.gz path, and maybe even the github https://github.com/madler/zlib/archive/v1.2.8.tar.gz one too)
  5. option to be avoided: increment releases automatically (would likely eventually cause many people pain similar to this issue if there was an unexpected regression or breakage)
  6. ?
  7. Profit!

:-)

ahundt commented Jan 2, 2017

Suggested options for a permanent fix:

  1. The github release could be used for the relevant files, which @madler of zlib himself conveniently provides https://github.com/madler/zlib/releases, perhaps releases here can be consistently expected in the future?
  2. propose to zlib that they have a permalink available on zlib.net (or find/switch to it if it already exists)
  3. As the stewards of tensorflow, I assume google has, and they may want to use their own googley options and may want to use them. :-)
  4. Enable or make use of existing support for check more than one url location for redundancy which should be safe if the hash is correct and secure (i.e. provide both the normal http://zlib.net/zlib-1.2.8.tar.gz and fossils http://zlib.net/fossils/zlib-1.2.8.tar.gz path, and maybe even the github https://github.com/madler/zlib/archive/v1.2.8.tar.gz one too)
  5. option to be avoided: increment releases automatically (would likely eventually cause many people pain similar to this issue if there was an unexpected regression or breakage)
  6. ?
  7. Profit!

:-)

@madler

This comment has been minimized.

Show comment
Hide comment
@madler

madler Jan 2, 2017

There is already a permanent link for the current version: http://zlib.net/current/zlib.tar.gz .

madler commented Jan 2, 2017

There is already a permanent link for the current version: http://zlib.net/current/zlib.tar.gz .

@adamcrume

This comment has been minimized.

Show comment
Hide comment
@adamcrume

adamcrume Jan 2, 2017

Contributor

Linking to the current version means that builds might not be repeatable. (Of course, unexpected 404s lead to non-repeatable builds, too.)

Contributor

adamcrume commented Jan 2, 2017

Linking to the current version means that builds might not be repeatable. (Of course, unexpected 404s lead to non-repeatable builds, too.)

@ParkerLowrey

This comment has been minimized.

Show comment
Hide comment
@ParkerLowrey

ParkerLowrey Jan 2, 2017

I think this has been fixed in the master branch already:
urls = [ "http://bazel-mirror.storage.googleapis.com/zlib.net/zlib-1.2.8.tar.gz", "http://zlib.net/zlib-1.2.8.tar.gz", ],
(although the second url is now dead).

ParkerLowrey commented Jan 2, 2017

I think this has been fixed in the master branch already:
urls = [ "http://bazel-mirror.storage.googleapis.com/zlib.net/zlib-1.2.8.tar.gz", "http://zlib.net/zlib-1.2.8.tar.gz", ],
(although the second url is now dead).

@ahundt

This comment has been minimized.

Show comment
Hide comment
@ahundt

ahundt Jan 3, 2017

@madler thanks for your reply! Unfortunately, a permanent link to the ever changing current version would make it difficult for a user to return to a version they previously had installed in an automated fashion if the link downloads different things now from what it downloads in the future. Plus bazel (and many other build tools) also require a hash so I think with the link you specified the breakage in this github issue would just recur the next time the version changed.

@ParkerLowrey ah if the bazel-mirror link is in master then I bet if a google developer can cherry-pick that change to the r0.12 branch it would be fixed!

ahundt commented Jan 3, 2017

@madler thanks for your reply! Unfortunately, a permanent link to the ever changing current version would make it difficult for a user to return to a version they previously had installed in an automated fashion if the link downloads different things now from what it downloads in the future. Plus bazel (and many other build tools) also require a hash so I think with the link you specified the breakage in this github issue would just recur the next time the version changed.

@ParkerLowrey ah if the bazel-mirror link is in master then I bet if a google developer can cherry-pick that change to the r0.12 branch it would be fixed!

@madler

This comment has been minimized.

Show comment
Hide comment
@madler

madler Jan 3, 2017

As already noted, all of the versions are in http://zlib.net/fossils/ , including the current version.

madler commented Jan 3, 2017

As already noted, all of the versions are in http://zlib.net/fossils/ , including the current version.

ahundt added a commit to ahundt/tensorflow that referenced this issue Jan 3, 2017

worspace.bzl uses zlib permalink
zlib permalinks including the current version are always in http://zlib.net/fossils/zlib-*.*.*.tar.gz
links in http://zlib.net/zlib-*.*.*.tar.gz are removed when no longer current.

Should resolve #6594 if merged into r0.12 branch.
@ahundt

This comment has been minimized.

Show comment
Hide comment
@ahundt

ahundt Jan 3, 2017

@madler perfect! Thanks again for taking the time to give feedback.

Now with the bazel-mirror and knowing that the fossils links are permalinks I believe #6612 will resolve this if merged into r0.12.

ahundt commented Jan 3, 2017

@madler perfect! Thanks again for taking the time to give feedback.

Now with the bazel-mirror and knowing that the fossils links are permalinks I believe #6612 will resolve this if merged into r0.12.

@madler

This comment has been minimized.

Show comment
Hide comment
@madler

madler Jan 3, 2017

By the way, the current version is 1.2.10.

madler commented Jan 3, 2017

By the way, the current version is 1.2.10.

@ronrest

This comment has been minimized.

Show comment
Hide comment
@ronrest

ronrest Jan 4, 2017

Contributor

Are any of the code suggestions working for anyone? I tried the code suggested by seungryulchoisc and the code in ahundt's commit

But i still get the following errors when trying to compile from source on an Amazon P2 instance using TF_UNOFFICIAL_SETTING=1 ./configure

ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '//tensorflow/core:lib_internal'.
ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '//tensorflow/core:lib_internal'.
ERROR: /home/ubuntu/.cache/bazel/_bazel_ubuntu/ad1e09741bb4109fbc70ef8216b59ee2/external/png_archive/BUILD:6:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '@png_archive//:png'.
ERROR: Evaluation of query "deps((//tensorflow/... union @bazel_tools//tools/jdk:toolchain))" failed: errors were encountered while computing transitive closure.

I have tried using different versions of Bazel, 0.4.3, 0.4.2, and 0.3.2 (0.3.2 doesn't like "urls", so i made it a single "url" when testing with 0.3.2).

Contributor

ronrest commented Jan 4, 2017

Are any of the code suggestions working for anyone? I tried the code suggested by seungryulchoisc and the code in ahundt's commit

But i still get the following errors when trying to compile from source on an Amazon P2 instance using TF_UNOFFICIAL_SETTING=1 ./configure

ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '//tensorflow/core:lib_internal'.
ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:970:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '//tensorflow/core:lib_internal'.
ERROR: /home/ubuntu/.cache/bazel/_bazel_ubuntu/ad1e09741bb4109fbc70ef8216b59ee2/external/png_archive/BUILD:6:1: no such package '@zlib_archive//': BUILD file not found on package path and referenced by '@png_archive//:png'.
ERROR: Evaluation of query "deps((//tensorflow/... union @bazel_tools//tools/jdk:toolchain))" failed: errors were encountered while computing transitive closure.

I have tried using different versions of Bazel, 0.4.3, 0.4.2, and 0.3.2 (0.3.2 doesn't like "urls", so i made it a single "url" when testing with 0.3.2).

@beniz

This comment has been minimized.

Show comment
Hide comment
@beniz

beniz Jan 4, 2017

Simple fix that has been working for me for days:

  • edit tensorflow/workspace.bzl
  • replace zlib-1.2.8 with zlib-1.2.10
  • remove the sha256 line

or use this patch:

diff --git a/tensorflow/workspace.bzl b/tensorflow/workspace.bzl
index 06e16cd..7c7b44c 100644
--- a/tensorflow/workspace.bzl
+++ b/tensorflow/workspace.bzl
@@ -228,9 +228,8 @@ def tf_workspace(path_prefix = "", tf_repo_name = ""):
 
   native.new_http_archive(
     name = "zlib_archive",
-    url = "http://zlib.net/zlib-1.2.8.tar.gz",
-    sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
-    strip_prefix = "zlib-1.2.8",
+    url = "http://zlib.net/zlib-1.2.10.tar.gz",
+    strip_prefix = "zlib-1.2.10",
     build_file = str(Label("//:zlib.BUILD")),
   )

beniz commented Jan 4, 2017

Simple fix that has been working for me for days:

  • edit tensorflow/workspace.bzl
  • replace zlib-1.2.8 with zlib-1.2.10
  • remove the sha256 line

or use this patch:

diff --git a/tensorflow/workspace.bzl b/tensorflow/workspace.bzl
index 06e16cd..7c7b44c 100644
--- a/tensorflow/workspace.bzl
+++ b/tensorflow/workspace.bzl
@@ -228,9 +228,8 @@ def tf_workspace(path_prefix = "", tf_repo_name = ""):
 
   native.new_http_archive(
     name = "zlib_archive",
-    url = "http://zlib.net/zlib-1.2.8.tar.gz",
-    sha256 = "36658cb768a54c1d4dec43c3116c27ed893e88b02ecfcb44f2166f9c0b7f2a0d",
-    strip_prefix = "zlib-1.2.8",
+    url = "http://zlib.net/zlib-1.2.10.tar.gz",
+    strip_prefix = "zlib-1.2.10",
     build_file = str(Label("//:zlib.BUILD")),
   )

@vrv vrv closed this in #6612 Jan 5, 2017

vrv added a commit that referenced this issue Jan 5, 2017

worspace.bzl uses zlib permalink (#6612)
* worspace.bzl uses zlib permalink

zlib permalinks including the current version are always in http://zlib.net/fossils/zlib-*.*.*.tar.gz
links in http://zlib.net/zlib-*.*.*.tar.gz are removed when no longer current.

Should resolve #6594 if merged into r0.12 branch.

* Remove comment, moving to git commit description.

adamcrume added a commit to adamcrume/tensorflow-rust that referenced this issue Jan 8, 2017

@soupault

This comment has been minimized.

Show comment
Hide comment
@soupault

soupault Jan 18, 2017

Patch from adamcrume/tensorflow-rust@84cc473 helped me to configure for 0.11 build.

soupault commented Jan 18, 2017

Patch from adamcrume/tensorflow-rust@84cc473 helped me to configure for 0.11 build.

@Omnipresent

This comment has been minimized.

Show comment
Hide comment
@Omnipresent

Omnipresent Feb 2, 2017

I'm still getting this error after the changes from @beniz

I get the error when following along with this tutorial https://www.tensorflow.org/how_tos/image_retraining/ . I'm using the TFAMI.v3 - ami-0e969619 AMI

ubuntu@ip-172-31-35-11:~/tensorflow$ bazel build tensorflow/examples/image_retraining:retrain
ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:1017:1: no such package '@zlib_archive//': Error downloading [http://zlib.net/zlib-1.2.10.tar.gz] to /home/ubuntu/.cache/bazel/_bazel_ubuntu/ad1e09741bb4109fbc70ef8216b59ee2/external/zlib_archive/zlib-1.2.10.tar.gz: GET returned 404 Not Found and referenced by '//tensorflow/core:lib_internal'.
ERROR: Analysis of target '//tensorflow/examples/image_retraining:retrain' failed; build aborted.
INFO: Elapsed time: 5.315s

My release is 0.12.0

ubuntu@ip-172-31-35-11:~/tensorflow$ grep "Release" -m 1 RELEASE.md
# Release 0.12.0

In tensorflow/workspace.bzl I've placed the following:


  native.new_http_archive(
    name = "zlib_archive",
    url = "http://zlib.net/zlib-1.2.10.tar.gz",
    strip_prefix = "zlib-1.2.10",
    build_file = str(Label("//:zlib.BUILD")),
  )

Omnipresent commented Feb 2, 2017

I'm still getting this error after the changes from @beniz

I get the error when following along with this tutorial https://www.tensorflow.org/how_tos/image_retraining/ . I'm using the TFAMI.v3 - ami-0e969619 AMI

ubuntu@ip-172-31-35-11:~/tensorflow$ bazel build tensorflow/examples/image_retraining:retrain
ERROR: /home/ubuntu/tensorflow/tensorflow/core/BUILD:1017:1: no such package '@zlib_archive//': Error downloading [http://zlib.net/zlib-1.2.10.tar.gz] to /home/ubuntu/.cache/bazel/_bazel_ubuntu/ad1e09741bb4109fbc70ef8216b59ee2/external/zlib_archive/zlib-1.2.10.tar.gz: GET returned 404 Not Found and referenced by '//tensorflow/core:lib_internal'.
ERROR: Analysis of target '//tensorflow/examples/image_retraining:retrain' failed; build aborted.
INFO: Elapsed time: 5.315s

My release is 0.12.0

ubuntu@ip-172-31-35-11:~/tensorflow$ grep "Release" -m 1 RELEASE.md
# Release 0.12.0

In tensorflow/workspace.bzl I've placed the following:


  native.new_http_archive(
    name = "zlib_archive",
    url = "http://zlib.net/zlib-1.2.10.tar.gz",
    strip_prefix = "zlib-1.2.10",
    build_file = str(Label("//:zlib.BUILD")),
  )
@Omnipresent

This comment has been minimized.

Show comment
Hide comment
@Omnipresent

Omnipresent Feb 2, 2017

The below works. Thanks @ahundt for updating the edit

  native.new_http_archive(
    name = "zlib_archive",
    url = "http://zlib.net/fossils/zlib-1.2.10.tar.gz",
    strip_prefix = "zlib-1.2.8",
    build_file = str(Label("//:zlib.BUILD")),
  )

Omnipresent commented Feb 2, 2017

The below works. Thanks @ahundt for updating the edit

  native.new_http_archive(
    name = "zlib_archive",
    url = "http://zlib.net/fossils/zlib-1.2.10.tar.gz",
    strip_prefix = "zlib-1.2.8",
    build_file = str(Label("//:zlib.BUILD")),
  )

bhbai added a commit to bhbai/tensorflow that referenced this issue Feb 6, 2017

Update workspace.bzl
According  tensorflow#6594
1.Permanent link for the current version: http://zlib.net/current/zlib.tar.gz 
2. http://zlib.net/fossils/ is stored all the archived build

I preferred the 2nd choice.
@skullkey

This comment has been minimized.

Show comment
Hide comment
@skullkey

skullkey Feb 10, 2017

Thanks @Omnipresent

After applying your edit to workspace.bzl,I got:
Prefix zlib-1.2.8 was given, but not found in the archive and referenced by '//tensorflow/core:lib_internal'.

Changing the entry as follows worked for me:

    native.new_http_archive(
        name = "zlib_archive",
        url = "http://zlib.net/fossils/zlib-1.2.10.tar.gz",
        strip_prefix = "zlib-1.2.10",
        build_file = str(Label("//:zlib.BUILD")),
    )

I am using TFAMI.v3 (ami-52bb0c32)

skullkey commented Feb 10, 2017

Thanks @Omnipresent

After applying your edit to workspace.bzl,I got:
Prefix zlib-1.2.8 was given, but not found in the archive and referenced by '//tensorflow/core:lib_internal'.

Changing the entry as follows worked for me:

    native.new_http_archive(
        name = "zlib_archive",
        url = "http://zlib.net/fossils/zlib-1.2.10.tar.gz",
        strip_prefix = "zlib-1.2.10",
        build_file = str(Label("//:zlib.BUILD")),
    )

I am using TFAMI.v3 (ami-52bb0c32)

@madhutummi

This comment has been minimized.

Show comment
Hide comment
@madhutummi

madhutummi Apr 5, 2017

@skullkey I have modified workspace.bzl as per your changes, now I get the below error
"ERROR: /tensorflow/core/BUILD:853:1: no such package '@zlib_archive//': Unable to load package for //:zlib.BUILD: not found. and referenced by '//tensorflow/core:lib_internal'."

I am using bazel-0.4.0 binaries build from sources.

Any idea how to fix it?

Thanks
Madhu

madhutummi commented Apr 5, 2017

@skullkey I have modified workspace.bzl as per your changes, now I get the below error
"ERROR: /tensorflow/core/BUILD:853:1: no such package '@zlib_archive//': Unable to load package for //:zlib.BUILD: not found. and referenced by '//tensorflow/core:lib_internal'."

I am using bazel-0.4.0 binaries build from sources.

Any idea how to fix it?

Thanks
Madhu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment