Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing semicolon at the end of line #15772

Merged
merged 1 commit into from Jan 1, 2018

Conversation

@dongsam
Copy link
Contributor

commented Jan 1, 2018

removed trailing semicolon(;) in the statement

according to Google Python Style Guide
"Do not terminate your lines with semi-colons and do not use semi-colons to put two commands on the same line."

@tensorflow-jenkins

This comment has been minimized.

Copy link
Collaborator

commented Jan 1, 2018

Can one of the admins verify this patch?

@googlebot

This comment has been minimized.

Copy link

commented Jan 1, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Jan 1, 2018

@dongsam

This comment has been minimized.

Copy link
Contributor Author

commented Jan 1, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Jan 1, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 1, 2018

@drpngx

drpngx approved these changes Jan 1, 2018

@drpngx

This comment has been minimized.

Copy link
Contributor

commented Jan 1, 2018

Jenkins, test this please.

@kokoro-team kokoro-team removed the kokoro:run label Jan 1, 2018

@drpngx drpngx merged commit 77f51ee into tensorflow:master Jan 1, 2018

18 checks passed

Android Demo App Internal CI build successful
Details
GPU CC Internal CI build successful
Details
GPU Python3 Internal CI build successful
Details
Linux CPU Tests (Python 3) SUCCESS
Details
MacOS Contrib Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Sanity Checks SUCCESS
Details
TF Test Suite SUCCESS
Details
Ubuntu CC Internal CI build successful
Details
Ubuntu Makefile Internal CI build successful
Details
Ubuntu Python2 Internal CI build successful
Details
Ubuntu Python3 Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Ubuntu contrib Internal CI build successful
Details
Windows Cmake Tests SUCCESS
Details
XLA Internal CI build successful
Details
ci.tensorflow.org SUCCESS
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.