Skip to content

remove trailing semicolon at the end of line #15772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2018

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Jan 1, 2018

removed trailing semicolon(;) in the statement

according to Google Python Style Guide
"Do not terminate your lines with semi-colons and do not use semi-colons to put two commands on the same line."

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@dongsam
Copy link
Contributor Author

dongsam commented Jan 1, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 1, 2018
@drpngx
Copy link
Contributor

drpngx commented Jan 1, 2018

Jenkins, test this please.

@drpngx drpngx merged commit 77f51ee into tensorflow:master Jan 1, 2018
copybara-service bot pushed a commit that referenced this pull request Aug 7, 2024
Imported from GitHub PR openxla/xla#15772

This PR adds dumping of the gemm fusions dot visualization when flag xla_gpu_dump_autotuned_gemm_fusions is set.

by dumping the fusion module we can visualize entry_computation for the specific fusion instead of going through the html visualization--which contains more information but quite a lot slower to render and use.

Copybara import of the project:

--
3850eeefe17f9a6e084657bf888b6d27156ab9a3 by Amir Samani <asamani@nvidia.com>:

dump fusion in dot format when dumping fusion flag is set

Merging this change closes #15772

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15772 from Amir-19:gemm_fusion_dump_dot 3850eeefe17f9a6e084657bf888b6d27156ab9a3
PiperOrigin-RevId: 660281981
copybara-service bot pushed a commit that referenced this pull request Aug 7, 2024
Imported from GitHub PR openxla/xla#15772

This PR adds dumping of the gemm fusions dot visualization when flag xla_gpu_dump_autotuned_gemm_fusions is set.

by dumping the fusion module we can visualize entry_computation for the specific fusion instead of going through the html visualization--which contains more information but quite a lot slower to render and use.

Copybara import of the project:

--
3850eeefe17f9a6e084657bf888b6d27156ab9a3 by Amir Samani <asamani@nvidia.com>:

dump fusion in dot format when dumping fusion flag is set

Merging this change closes #15772

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#15772 from Amir-19:gemm_fusion_dump_dot 3850eeefe17f9a6e084657bf888b6d27156ab9a3
PiperOrigin-RevId: 660281981
copybara-service bot pushed a commit that referenced this pull request Aug 7, 2024
Imported from GitHub PR openxla/xla#15772

This PR adds dumping of the gemm fusions dot visualization when flag xla_gpu_dump_autotuned_gemm_fusions is set.

by dumping the fusion module we can visualize entry_computation for the specific fusion instead of going through the html visualization--which contains more information but quite a lot slower to render and use.

Copybara import of the project:

--
3850eeefe17f9a6e084657bf888b6d27156ab9a3 by Amir Samani <asamani@nvidia.com>:

dump fusion in dot format when dumping fusion flag is set

Merging this change closes #15772

PiperOrigin-RevId: 660299704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants