New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKL: Making MKL-DNN default #16474

Merged
merged 2 commits into from Jan 26, 2018

Conversation

Projects
None yet
6 participants
@agramesh1
Contributor

agramesh1 commented Jan 26, 2018

Make Tensroflow use MKL DNN by default if --config=mkl is used when building

@googlebot

This comment has been minimized.

googlebot commented Jan 26, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Jan 26, 2018

@rmlarsen rmlarsen requested a review from andydavis1 Jan 26, 2018

@rmlarsen rmlarsen self-assigned this Jan 26, 2018

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Jan 26, 2018

@agramesh1 Thanks for the PR. Please sign the CLA.

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Jan 26, 2018

@agramesh1 Please rebase.

@agramesh1

This comment has been minimized.

Contributor

agramesh1 commented Jan 26, 2018

@rmlarsen ok will rebase.

@googlebot

This comment has been minimized.

googlebot commented Jan 26, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 26, 2018

@agramesh1

This comment has been minimized.

Contributor

agramesh1 commented Jan 26, 2018

@rmlarsen rebase completed.

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Jan 26, 2018

@agramesh1 Thanks!

@andydavis1

This comment has been minimized.

Member

andydavis1 commented Jan 26, 2018

@tensorflow-jenkins test this please

@rmlarsen

This comment has been minimized.

Member

rmlarsen commented Jan 26, 2018

@andydavis1 Thanks, for reviewing. I can sheperd this PR along from here.

@rmlarsen rmlarsen merged commit e4a628a into tensorflow:master Jan 26, 2018

15 checks passed

Android Demo App Internal CI build successful
Details
GPU CC Internal CI build successful
Details
GPU Python3 Internal CI build successful
Details
MacOS Contrib Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Ubuntu CC Internal CI build successful
Details
Ubuntu Makefile Internal CI build successful
Details
Ubuntu Python2 Internal CI build successful
Details
Ubuntu Python3 Internal CI build successful
Details
Ubuntu Python3 PIP Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Ubuntu contrib Internal CI build successful
Details
Windows CMake Internal CI build successful
Details
XLA Internal CI build successful
Details
cla/google All necessary CLAs are signed
@agramesh1

This comment has been minimized.

Contributor

agramesh1 commented Jan 27, 2018

@rmlarsen thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment