New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Typos #18806

Merged
merged 13 commits into from May 3, 2018

Conversation

Projects
None yet
6 participants
@nnadeau
Contributor

nnadeau commented Apr 23, 2018


This change is Reviewable

@googlebot

This comment has been minimized.

googlebot commented Apr 23, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no label Apr 23, 2018

@nnadeau

This comment has been minimized.

Contributor

nnadeau commented Apr 23, 2018

I signed it!

@googlebot

This comment has been minimized.

googlebot commented Apr 23, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

nnadeau added some commits Apr 23, 2018

@nnadeau nnadeau force-pushed the nnadeau:typos branch from 0ab5a72 to e36dc43 Apr 23, 2018

@googlebot

This comment has been minimized.

googlebot commented Apr 23, 2018

CLAs look good, thanks!

@@ -789,7 +789,7 @@
" 2000 : 1.69528644681 learning rate: 10.0\n",
"Minibatch perplexity: 5.13\n",
"================================================================================\n",
"vers soqually have one five landwing to docial page kagan lower with ther batern\n",
"vers soqually have one five landwing to docial page kagan lower with there batern\n",

This comment has been minimized.

@ekelsen

ekelsen Apr 26, 2018

Contributor

It's not clear that this should be changed.

@ekelsen

This comment has been minimized.

Contributor

ekelsen commented Apr 26, 2018

LGTM, except for the one case where I think the suggestion should be reverted.

Revert "fixed examples typo"
This reverts commit a5fc20e.
@nnadeau

This comment has been minimized.

Contributor

nnadeau commented Apr 27, 2018

@ekelsen c86e47c reverts the overzealous change 😛

@@ -163,7 +163,7 @@ def while_loop(loop_cond, loop_body, init_state, extra_deps, opts=None):
Tuple containing the final state.
"""
# TODO(mdan): Consider adding a generic mechanism for dynamic dispatch.
# That could be somethins as simple as a collection of dispatch rules, with
# That could be somethings as simple as a collection of dispatch rules, with

This comment has been minimized.

@av8ramit

av8ramit Apr 30, 2018

Member

"something"?

@caisq

This comment has been minimized.

Contributor

caisq commented May 1, 2018

Ping @nnadeau

@nnadeau

This comment has been minimized.

Contributor

nnadeau commented May 1, 2018

@av8ramit @caisq extra 's' removed in 08a3319

@caisq caisq dismissed stale reviews from av8ramit and themself via 9b8652e May 3, 2018

@caisq caisq merged commit 487fa7b into tensorflow:master May 3, 2018

10 of 16 checks passed

GPU Python3 Internal CI build started.
Details
MacOS Contrib Internal CI build started.
Details
MacOS Python2 and CC Internal CI build started.
Details
Ubuntu Python3 PIP Internal CI build started.
Details
Windows CMake Internal CI build started.
Details
XLA Internal CI build started.
Details
Android Demo App Internal CI build successful
Details
GPU CC Internal CI build successful
Details
Ubuntu CC Internal CI build successful
Details
Ubuntu Makefile Internal CI build successful
Details
Ubuntu Python2 Internal CI build successful
Details
Ubuntu Python3 Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Ubuntu contrib Internal CI build successful
Details
Windows Bazel Internal CI build successful
Details
cla/google All necessary CLAs are signed

@nnadeau nnadeau deleted the nnadeau:typos branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment