Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flatten_atrous_conv doc #27145

Closed
wants to merge 1 commit into from
Closed

Fix flatten_atrous_conv doc #27145

wants to merge 1 commit into from

Conversation

lee-bin
Copy link

@lee-bin lee-bin commented Mar 26, 2019

No description provided.

@lee-bin lee-bin mentioned this pull request Mar 26, 2019
Closed
gshashank84
gshashank84 reviewed Mar 26, 2019
View reviewed changes
Copy link
Contributor

@gshashank84 gshashank84 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here when we Upsample all the Conv2D operations by using this transform first, then we will use fold_constants for converting all the operations above into constant expressions, and then you can further run fold_batch_norms

@rthadur rthadur self-assigned this Mar 26, 2019
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Mar 26, 2019
@rthadur rthadur added awaiting review Pull request awaiting review size:XS CL Change Size: Extra Small labels Mar 26, 2019
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 26, 2019
@rthadur rthadur requested a review from drpngx March 26, 2019 17:57
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 27, 2019
@rthadur rthadur requested a review from protoget March 27, 2019 22:23
@rthadur rthadur requested review from ymodak and dynamicwebpaige and removed request for protoget, drpngx and ymodak May 8, 2019 01:27
@rthadur rthadur requested review from ymodak and removed request for dynamicwebpaige June 18, 2019 21:48
@rthadur
Copy link
Contributor

rthadur commented Jun 26, 2019

I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen!

@rthadur rthadur closed this Jun 26, 2019
PR Queue automation moved this from Approved by Reviewer to Closed/Rejected Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshashank84 gshashank84 gshashank84 approved these changes

@Harshini-Gadige Harshini-Gadige Harshini-Gadige approved these changes

@ymodak ymodak Awaiting requested review from ymodak

Assignees

@rthadur rthadur

Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Closed/Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lee-bin @rthadur @gshashank84 @Harshini-Gadige @googlebot @tensorflowbutler