Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Oxford comma in README.md #27558

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
6 participants
@Yoshimitsu
Copy link
Contributor

commented Apr 6, 2019

Added an Oxford comma to line 28, to be consistent with the rest of the file.

Added Oxford comma in README.md
Added an Oxford comma to line 28, to be consistent with the rest of the file.
@googlebot

This comment has been minimized.

Copy link

commented Apr 6, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Apr 6, 2019

@Yoshimitsu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Apr 6, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Apr 6, 2019

@rthadur rthadur self-assigned this Apr 7, 2019

@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Apr 7, 2019

@rthadur

This comment has been minimized.

Copy link
Contributor

commented Apr 7, 2019

@Yoshimitsu thank you for your contribution , i don't think we need this change.

@rthadur rthadur closed this Apr 7, 2019

PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Apr 7, 2019

@lamberta lamberta reopened this Apr 8, 2019

PR Queue automation moved this from Closed/Rejected to Assigned Reviewer Apr 8, 2019

@lamberta

This comment has been minimized.

Copy link
Member

commented Apr 8, 2019

Hi Alex, thanks for the PR and improving the docs!
I think this is a good change and is in line with the Google Developer Docs style guide: https://developers.google.com/style/commas

@rthadur rthadur requested a review from lamberta Apr 9, 2019

@lamberta
Copy link
Member

left a comment

Thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 9, 2019

@tensorflow-copybara tensorflow-copybara merged commit d3b1a41 into tensorflow:master Apr 9, 2019

11 of 15 checks passed

Ubuntu Makefile Internal CI build failed
Details
Ubuntu Python3 PIP Internal CI build failed
Details
Windows Bazel Internal CI build failed
Details
Windows Bazel GPU Internal CI build failed
Details
Android Demo App Internal CI build successful
Details
Linux GPU Internal CI build successful
Details
MacOS Contrib Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Ubuntu CC Internal CI build successful
Details
Ubuntu Python2 Internal CI build successful
Details
Ubuntu Python3 Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Ubuntu contrib Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details

PR Queue automation moved this from Approved by Reviewer to Merged Apr 9, 2019

tensorflow-copybara pushed a commit that referenced this pull request Apr 9, 2019

Merge pull request #27558 from Yoshimitsu:patch-1
PiperOrigin-RevId: 242755194
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.