Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r2.0-CherryPick]:Keras SavedModel important bug fixes and refactor #32306

Merged
merged 4 commits into from Sep 7, 2019
Merged

[r2.0-CherryPick]:Keras SavedModel important bug fixes and refactor #32306

merged 4 commits into from Sep 7, 2019

Conversation

k-w-w
Copy link
Contributor

@k-w-w k-w-w commented Sep 6, 2019

  1. Use of external tensors (e.g., generated by tf.sequence_mask) are converted to constants when saving.
  2. Fixed error preventing models with @tf.function decorated calls from being exported.
  3. Refactored Keras Serialization code (this change must be cherrypicked for the other two commits to be pushed)

@k-w-w
Remove SavedModel-specific methods from base Layer and Model, and add…
91658fa 
… documentation for updating the serialization implementation.

PiperOrigin-RevId: 266978650
@k-w-w
Convert tensors to constants when saving Keras functional and graph m…
cc9422d 
…odels to SavedModel.

This includes changes to backend.get_value() to ensure that the correct graph context created when getting the value of a tensor.

PiperOrigin-RevId: 267498198
@k-w-w
If layer's call function is wrapped in tf.function, then trace the or…
960c3ba 
…iginal method instead of the the wrapped function.

This avoids the issue where canonicalize_function_inputs added an additional defaults to the `args` list.

PiperOrigin-RevId: 267650429
@tensorflow-bot tensorflow-bot bot added the size:XL CL Change Size:Extra Large label Sep 6, 2019
@k-w-w k-w-w mentioned this pull request Sep 6, 2019
Closed
@k-w-w
Remove dedupe_weights @Property
f9494f2 
Accidentally left it in the commit.
@goldiegadde goldiegadde self-assigned this Sep 7, 2019
@goldiegadde goldiegadde merged commit dc36339 into tensorflow:r2.0 Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldiegadde goldiegadde goldiegadde approved these changes

Assignees

@goldiegadde goldiegadde

Labels
cla: yes size:XL CL Change Size:Extra Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-w-w @goldiegadde @googlebot