Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tf.keras.backend.bias_add #33270

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@lgeiger
Copy link
Contributor

lgeiger commented Oct 12, 2019

tf.nn.bias_add now supports channels_first and inputs up to rank 5. This means that the implementation of tf.keras.backend.bias_add can be greatly simplified by relying directly on tf.nn.bias_add. This should also slightly increase performance since in most cases it can directly rely on tf.nn.bias_add.

@tensorflow-bot tensorflow-bot bot added the size:M label Oct 12, 2019
@googlebot googlebot added the cla: yes label Oct 12, 2019
@gbaned gbaned self-assigned this Oct 14, 2019
@gbaned gbaned added the comp:keras label Oct 14, 2019
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 14, 2019
@gbaned gbaned requested a review from fchollet Oct 14, 2019
@lgeiger

This comment has been minimized.

Copy link
Contributor Author

lgeiger commented Nov 16, 2019

@fchollet Any change you could take a look or reassign the PR?

@gbaned gbaned requested a review from qlzh727 Nov 25, 2019
Copy link
Member

qlzh727 left a comment

Sorry for the long wait.

tensorflow/python/keras/backend.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 6, 2020
@gbaned

This comment has been minimized.

Copy link
Contributor

gbaned commented Jan 8, 2020

@lgeiger Could you please check reviewer comments and keep us posted. Thanks!

@lgeiger lgeiger force-pushed the lgeiger:keras-bias-add branch from fcd7978 to 80c74c2 Jan 8, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 8, 2020
@lgeiger lgeiger force-pushed the lgeiger:keras-bias-add branch from 80c74c2 to bb23a59 Jan 8, 2020
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jan 8, 2020
@lgeiger

This comment has been minimized.

Copy link
Contributor Author

lgeiger commented Jan 8, 2020

pylint wasn't happy about this change, I fixed it in the latest commit. Sorry about that.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 13, 2020
@gbaned gbaned added ready to pull and removed ready to pull labels Jan 13, 2020
tensorflow-copybara pushed a commit that referenced this pull request Jan 13, 2020
PiperOrigin-RevId: 289402141
Change-Id: I77c412ef992ae422d2d0abc4fcec5f27c3d6aa84
@tensorflow-copybara tensorflow-copybara merged commit bb23a59 into tensorflow:master Jan 13, 2020
10 checks passed
10 checks passed
Android Demo App Internal CI build successful
Details
Linux GPU Internal CI build successful
Details
MacOS CPU Python3 Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Ubuntu CPU Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Windows Bazel Internal CI build successful
Details
Windows Bazel GPU Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
PR Queue automation moved this from Approved by Reviewer to Merged Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Queue
  
Merged
7 participants
You can’t perform that action at this time.