Skip to content

update docstring of TopKCategoricalAccuracy#33460

Closed
btel wants to merge 1 commit intotensorflow:masterfrom
btel:patch-2
Closed

update docstring of TopKCategoricalAccuracy#33460
btel wants to merge 1 commit intotensorflow:masterfrom
btel:patch-2

Conversation

@btel
Copy link

@btel btel commented Oct 17, 2019

It's a simple edit that replaces capital K with k, which is more consistent with the parameter names of the metrics classes.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tensorflow-bot tensorflow-bot bot added the size:XS CL Change Size: Extra Small label Oct 17, 2019
@btel
Copy link
Author

btel commented Oct 17, 2019

@googlebot rescan

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rthadur rthadur self-assigned this Oct 17, 2019
@rthadur
Copy link
Contributor

rthadur commented Oct 17, 2019

We will not be encouraging one liner grammatical changes as this is expensive process, thank you for your interest.
CC @mihaimaruseac

@rthadur rthadur closed this Oct 17, 2019
@mihaimaruseac mihaimaruseac added the invalid Hacktoberfest spam PR label Oct 17, 2019
@btel
Copy link
Author

btel commented Oct 18, 2019

@rthadur Thank you for your consideration and your time. Although I understand your point, I still do believe that small incremental changes in the documentation might improve developer experience.

@btel btel deleted the patch-2 branch October 18, 2019 09:58
@mihaimaruseac
Copy link
Contributor

Every PR takes around 16 CPU/GPU hours of CI. As such, we cannot just run every PR through the CI infrastructure.

If you want to make documentation changes, please pick an entire file and clean it up from end to end, not just a letter here and there.

@btel
Copy link
Author

btel commented Oct 18, 2019

Thank you, @mihaimaruseac, for the explanation. I was put off by the tone of the initial copy-and-paste comment, but of course computational cost should be keept in mind. I would recommend updating the "Contributing guideline" to make the point clear for future contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes invalid Hacktoberfest spam PR size:XS CL Change Size: Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants