Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage example to tf.nn.conv2d() #35644

Merged
merged 12 commits into from Jan 13, 2020
Merged

Conversation

@boronhub
Copy link
Contributor

boronhub commented Jan 7, 2020

No description provided.

boronhub added 7 commits Dec 7, 2019
Gci task
@tensorflow-bot tensorflow-bot bot added the size:XS label Jan 7, 2020
@googlebot googlebot added the cla: yes label Jan 7, 2020
@gbaned gbaned self-assigned this Jan 8, 2020
@gbaned gbaned added the comp:ops label Jan 8, 2020
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 8, 2020
@gbaned gbaned requested a review from dynamicwebpaige Jan 8, 2020
@boronhub

This comment has been minimized.

Copy link
Contributor Author

boronhub commented Jan 8, 2020

@mihaimaruseac please review this

@mihaimaruseac

This comment has been minimized.

Copy link
Collaborator

mihaimaruseac commented Jan 8, 2020

All builds failed and there are conflicts to be fixed

Copy link
Collaborator

mihaimaruseac left a comment

Make sure you run the doctest locally as well as pylint.

tensorflow/python/ops/nn_ops.py Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 9, 2020
@mihaimaruseac

This comment has been minimized.

Copy link
Collaborator

mihaimaruseac commented Jan 9, 2020

The conflict still needs to be resolved.

Copy link
Collaborator

mihaimaruseac left a comment

I expect pylint to complain due to spacing in the lists (for example ],[ is not right, there should be a space after ,).

But let's run the tests and then you will have to fix the failures

@boronhub

This comment has been minimized.

Copy link
Contributor Author

boronhub commented Jan 9, 2020

I did pylint, it did not give any complaints.

@mihaimaruseac

This comment has been minimized.

Copy link
Collaborator

mihaimaruseac commented Jan 9, 2020

Perfect. Then what's left is to fix the ubuntu cpu error.

@boronhub boronhub requested a review from mihaimaruseac Jan 9, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 9, 2020
@rthadur

This comment has been minimized.

Copy link
Contributor

rthadur commented Jan 9, 2020

@mihaimaruseac there are some doctest failures , probably that needs to be fixed.

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jan 10, 2020
@rthadur rthadur requested a review from mihaimaruseac Jan 10, 2020
@rthadur

This comment has been minimized.

Copy link
Contributor

rthadur commented Jan 10, 2020

@boronhub it is still failing doctest , can you please check and run the doc test locally as mentioned here

@boronhub

This comment has been minimized.

Copy link
Contributor Author

boronhub commented Jan 11, 2020

@mihaimaruseac builds are passing

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 12, 2020
tensorflow-copybara pushed a commit that referenced this pull request Jan 13, 2020
PiperOrigin-RevId: 289441546
Change-Id: I601ba22f0638df86fae2144d22b8e9cf12acc610
@tensorflow-copybara tensorflow-copybara merged commit fdad318 into tensorflow:master Jan 13, 2020
10 checks passed
10 checks passed
Android Demo App Internal CI build successful
Details
Linux GPU Internal CI build successful
Details
MacOS CPU Python3 Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Ubuntu CPU Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Windows Bazel Internal CI build successful
Details
Windows Bazel GPU Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
PR Queue automation moved this from Approved by Reviewer to Merged Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.