From cd1a77fd5e6438b825cc90bd34706a8edeea809a Mon Sep 17 00:00:00 2001 From: Deven Desai Date: Tue, 14 Jan 2020 17:52:26 +0000 Subject: [PATCH] fixing a bug in the previous commit to nccl_manager_test.cc file. Also updating the run_cc_core.sh file to not filter out the ncc_manager_test --- tensorflow/core/nccl/nccl_manager_test.cc | 2 +- tensorflow/tools/ci_build/linux/rocm/run_cc_core.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tensorflow/core/nccl/nccl_manager_test.cc b/tensorflow/core/nccl/nccl_manager_test.cc index fcbae5622d68e3..3f9e6c62ef8769 100644 --- a/tensorflow/core/nccl/nccl_manager_test.cc +++ b/tensorflow/core/nccl/nccl_manager_test.cc @@ -663,8 +663,8 @@ TYPED_TEST(NcclManagerTest, MultiNodeBroadcast) { this->RunMultiNodeBroadcastTest(num_nodes, num_ranks_per_node, /*src_node=*/0, /*src_local_rank=*/0, /*in_place=*/true); -#endif } +#endif // Checks that we return error status if a collective_key is used for different // types of collectives, e.g.a reduction and a broadcast. diff --git a/tensorflow/tools/ci_build/linux/rocm/run_cc_core.sh b/tensorflow/tools/ci_build/linux/rocm/run_cc_core.sh index 0eb7fec7d9e10b..08d99f41622046 100755 --- a/tensorflow/tools/ci_build/linux/rocm/run_cc_core.sh +++ b/tensorflow/tools/ci_build/linux/rocm/run_cc_core.sh @@ -56,7 +56,7 @@ bazel test \ && bazel test \ --config=rocm \ -k \ - --test_tag_filters=-no_gpu,-no_rocm,-v1only \ + --test_tag_filters=gpu \ --jobs=${N_JOBS} \ --local_test_jobs=1 \ --test_timeout 600,900,2400,7200 \