Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair broken links #36157

Merged

Conversation

@z3dm4n
Copy link
Contributor

z3dm4n commented Jan 23, 2020

Fixes #36099

@tensorflow-bot tensorflow-bot bot added the size:XS label Jan 23, 2020
@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jan 23, 2020
@z3dm4n

This comment has been minimized.

Copy link
Contributor Author

z3dm4n commented Jan 23, 2020

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jan 23, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 23, 2020
@rthadur rthadur self-assigned this Jan 23, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jan 23, 2020
@rthadur rthadur added the type:docs label Jan 23, 2020
@rthadur rthadur requested a review from lamberta Jan 23, 2020
@rthadur rthadur removed this from Assigned Reviewer in PR Queue Jan 23, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jan 23, 2020
@lamberta lamberta requested a review from gargn Jan 23, 2020
@gargn
gargn approved these changes Jan 23, 2020
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jan 23, 2020
Copy link
Member

lamberta left a comment

Don't think we should point to the old docs. Perhaps just point to the website: https://www.tensorflow.org/lite/convert

Or these pages in GitHub: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/g3doc/convert

PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Jan 23, 2020
tensorflow/lite/toco/README.md Show resolved Hide resolved
@gargn

This comment has been minimized.

Copy link
Member

gargn commented Jan 23, 2020

Don't think we should point to the old docs. Perhaps just point to the website: https://www.tensorflow.org/lite/convert

Or these pages in GitHub: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/lite/g3doc/convert

I think this is the README for the old converter. The new convert is based off of this: https://github.com/tensorflow/tensorflow/blob/3cfbf14e80a4b5feb9e1a786e02ff705b42f83ef/tensorflow/lite/g3doc/convert/index.md

@rthadur rthadur removed the ready to pull label Jan 23, 2020
@z3dm4n z3dm4n requested a review from gargn Jan 24, 2020
@z3dm4n z3dm4n requested a review from lamberta Feb 2, 2020
Copy link
Member

lamberta left a comment

Thanks for the fix!

@gargn
gargn approved these changes Feb 3, 2020
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Feb 3, 2020
tensorflow-copybara pushed a commit that referenced this pull request Feb 3, 2020
PiperOrigin-RevId: 293002747
Change-Id: I3b5a1375ba597f9b85418449770a56f6501e29f2
@tensorflow-copybara tensorflow-copybara merged commit 994b6de into tensorflow:master Feb 3, 2020
9 of 10 checks passed
9 of 10 checks passed
Windows Bazel Internal CI build failed
Details
Android Demo App Internal CI build successful
Details
Linux GPU Internal CI build successful
Details
MacOS CPU Python3 Internal CI build successful
Details
MacOS Python2 and CC Internal CI build successful
Details
Ubuntu CPU Internal CI build successful
Details
Ubuntu Sanity Internal CI build successful
Details
Windows Bazel GPU Internal CI build successful
Details
cla/google All necessary CLAs are signed
import/copybara Change imported to the internal review system
Details
PR Queue automation moved this from Approved by Reviewer to Merged Feb 3, 2020
@z3dm4n z3dm4n deleted the z3dm4n:20200123_z3dm4n_fix_issue_36099 branch Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Queue
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.