Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `config=v1` as this is `r1.15` branch. #36190

Merged
merged 1 commit into from Jan 24, 2020
Merged

Conversation

@mihaimaruseac
Copy link
Collaborator

mihaimaruseac commented Jan 24, 2020

Otherwise, by default we were building V2 code on a v1 version.

Otherwise, by default we were building V2 code on a v1 version.
@mihaimaruseac mihaimaruseac requested review from gunan and goldiegadde Jan 24, 2020
@googlebot googlebot added the cla: yes label Jan 24, 2020
@mihaimaruseac mihaimaruseac requested a review from hyeygit Jan 24, 2020
@gunan
gunan approved these changes Jan 24, 2020
@mihaimaruseac mihaimaruseac merged commit e75a6d6 into r1.15 Jan 24, 2020
3 of 9 checks passed
3 of 9 checks passed
Ubuntu Sanity Internal CI build failed
Details
Windows Bazel GPU Internal CI build failed
Details
Linux GPU Internal CI build started.
Details
MacOS CPU Python3 Internal CI build started.
Details
MacOS Python2 and CC Internal CI build started.
Details
Windows Bazel Internal CI build started.
Details
Android Demo App Internal CI build successful
Details
Ubuntu CPU Internal CI build successful
Details
cla/google All necessary CLAs are signed
@mihaimaruseac mihaimaruseac deleted the mm-r1.15-fix-v2-build branch Jan 24, 2020
@vkuzmin-uber

This comment has been minimized.

Copy link

vkuzmin-uber commented Jan 25, 2020

I want to link it to issue #36179 for history.

btw, I found that 1.15.1 is ~5% slower than 1.12. I benchmarked resnet50_kears and simple tensorflow-addition.

Just in case I missed something, is it expected or this is regression to fix?

Not sure if I have resources to debug it but maybe I could compare with v2 after upgrade.

@mihaimaruseac

This comment has been minimized.

Copy link
Collaborator Author

mihaimaruseac commented Jan 25, 2020

There is a large difference between 1.12 and 1.15.1. A better comparison would be between 1.15.0 and 1.15.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.