Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited docstring, y_pred for SparseCategoricalAcc #37120

Merged
merged 5 commits into from Mar 16, 2020
Merged

Edited docstring, y_pred for SparseCategoricalAcc #37120

merged 5 commits into from Mar 16, 2020

Conversation

jaketae
Copy link
Contributor

@jaketae jaketae commented Feb 27, 2020

  1. The y_pred example was previously given as [0.1, 0.9, 0.8], which is odd given that the probabilities should sum up to one after passing through softmax. Edited to [0.1, 0.6, 0.3] to maintain integrity of example while posing a probable result.
  2. The docstring for master was not up-to-date with that of Tag 2.1.0. Made changes so that they are even.

Relates to #36844.

1. The y_pred example was previously given as `[0.1, 0.9, 0.8]`, which is odd given that the probabilities should sum up to one after passing through softmax. Edited to `[0.1, 0.6, 0.3]` to maintain integrity of example while posing a probable result.
2. The docstring for master was not up-to-date with that of Tag 2.1.0. Made changes so that they are even.
@tensorflow-bot tensorflow-bot bot added the size:S CL Change Size: Small label Feb 27, 2020
@rthadur rthadur self-assigned this Feb 27, 2020
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Feb 27, 2020
@rthadur rthadur added the comp:keras Keras related issues label Feb 27, 2020
@rthadur rthadur requested a review from pavithrasv March 4, 2020 19:04
@gbaned gbaned added the awaiting review Pull request awaiting review label Mar 12, 2020
Comment on lines 773 to 774
`acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1))`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend the following

Suggested change
`acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1))`
```python
acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I have incorporated the changes into the PR.

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Mar 14, 2020
Co-Authored-By: Mihai Maruseac <mihai.maruseac@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Mar 14, 2020
@tensorflow-bot tensorflow-bot bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 14, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 14, 2020
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 16, 2020
@tensorflow-copybara tensorflow-copybara merged commit 380aa9c into tensorflow:master Mar 16, 2020
PR Queue automation moved this from Approved by Reviewer to Merged Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:keras Keras related issues ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

9 participants