New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edited docstring, y_pred for SparseCategoricalAcc #37120
Edited docstring, y_pred for SparseCategoricalAcc #37120
Conversation
1. The y_pred example was previously given as `[0.1, 0.9, 0.8]`, which is odd given that the probabilities should sum up to one after passing through softmax. Edited to `[0.1, 0.6, 0.3]` to maintain integrity of example while posing a probable result. 2. The docstring for master was not up-to-date with that of Tag 2.1.0. Made changes so that they are even.
tensorflow/python/keras/metrics.py
Outdated
`acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1))` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend the following
`acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1))` | |
```python | |
acc = np.dot(sample_weight, np.equal(y_true, np.argmax(y_pred, axis=1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback. I have incorporated the changes into the PR.
Co-Authored-By: Mihai Maruseac <mihai.maruseac@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
y_pred
example was previously given as[0.1, 0.9, 0.8]
, which is odd given that the probabilities should sum up to one after passing through softmax. Edited to[0.1, 0.6, 0.3]
to maintain integrity of example while posing a probable result.Relates to #36844.