Cuda 11.1 cudart SO name fix #43716
Merged
Cuda 11.1 cudart SO name fix #43716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjoy
approved these changes
Oct 6, 2020
google-ml-butler
bot
added
kokoro:force-run
|
This is currently preventing TF and Jax builds on 11.1 (at least with Ampere cards). Making these changes to the bazel config fixes the issue. |
perfinion
added a commit
to perfinion/addons
that referenced
this pull request
Oct 27, 2020
libcudart soname in CUDA 11.x is versioned as 11.0 for backward compatability. This change is taken from tensorflow/tensorflow#43716 find_cuda_config.py was taken directly from TF (and reformatted with black). cusparse changed versioning in cuda11 so that part is needed. The other changes pulled in from TF is mostly more lib/header search paths and a few style changes. Signed-off-by: Jason Zaman <jason@perfinion.com>
7 tasks
seanpmorgan
added a commit
to tensorflow/addons
that referenced
this pull request
Nov 22, 2020
* Update cuda config for CUDA11.1 libcudart soname in CUDA 11.x is versioned as 11.0 for backward compatability. This change is taken from tensorflow/tensorflow#43716 find_cuda_config.py was taken directly from TF (and reformatted with black). cusparse changed versioning in cuda11 so that part is needed. The other changes pulled in from TF is mostly more lib/header search paths and a few style changes. Signed-off-by: Jason Zaman <jason@perfinion.com> * * Fix flake8 and formatting errors Co-authored-by: Sean Morgan <seanmorgan@outlook.com>
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Update cuda config for CUDA11.1 libcudart soname in CUDA 11.x is versioned as 11.0 for backward compatability. This change is taken from tensorflow/tensorflow#43716 find_cuda_config.py was taken directly from TF (and reformatted with black). cusparse changed versioning in cuda11 so that part is needed. The other changes pulled in from TF is mostly more lib/header search paths and a few style changes. Signed-off-by: Jason Zaman <jason@perfinion.com> * * Fix flake8 and formatting errors Co-authored-by: Sean Morgan <seanmorgan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CUDA 11.1 the soname of libcudart remains versioned as 11.0 for better backward comparability. This PR updates the configure scripts accordingly.
This should also address issue #43689
Attn @sanjoy