Skip to content

Add necessary check in fft ops to fix crash #55274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

yongtang
Copy link
Member

This PR tries to address the issue raised in #55263 where
tf.single.rfft2d will crash when length contains negative value.

This PR fixes #55263

Signed-off-by: Yong Tang yong.tang.github@outlook.com

This PR tries to address the issue raised in 55263 where
tf.single.rfft2d will crash when length contains negative value.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
…length < 0

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Mar 17, 2022
@yongtang yongtang requested a review from mihaimaruseac March 19, 2022 14:06
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 19, 2022
@gbaned gbaned added comp:core issues related to core part of tensorflow prtype:bugfix PR to fix a bug labels Mar 21, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 21, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 21, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Mar 23, 2022
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 23, 2022
@copybara-service copybara-service bot merged commit 0a8a781 into tensorflow:master Mar 23, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 23, 2022
@yongtang yongtang deleted the 55263-tf.signal.rfft2d branch March 23, 2022 17:20
mihaimaruseac pushed a commit that referenced this pull request May 8, 2022
mihaimaruseac pushed a commit that referenced this pull request May 8, 2022
mihaimaruseac pushed a commit that referenced this pull request May 8, 2022
mihaimaruseac added a commit that referenced this pull request May 8, 2022
…19b7d23d0a369e9ad73-on-r2.6

Merge pull request #55274 from yongtang:55263-tf.signal.rfft2d
mihaimaruseac added a commit that referenced this pull request May 8, 2022
…19b7d23d0a369e9ad73-on-r2.7

Merge pull request #55274 from yongtang:55263-tf.signal.rfft2d
mihaimaruseac added a commit that referenced this pull request May 8, 2022
…19b7d23d0a369e9ad73-on-r2.8

Merge pull request #55274 from yongtang:55263-tf.signal.rfft2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:core issues related to core part of tensorflow prtype:bugfix PR to fix a bug size:S CL Change Size: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tf.compat.v1.signal.rfft2d and rfft3d lacks input validation leading to crashes
5 participants