New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes two minor anchor link issues. #683
Conversation
Fixes two minor anchor link issues.
Thanks for checking over the last PR! It looks like I definitely missed changing the '#sources' links, so that's good. I was looking over the change on line 110 of adding_an_op/index.md, and after seeing where the links point, there might be an even better anchor to use. Moving to a line note for context. |
@@ -107,7 +107,7 @@ REGISTER_KERNEL_BUILDER(Name("ZeroOut").Device(DEVICE_CPU), ZeroOutOp); | |||
``` | |||
|
|||
Once you | |||
[build and reinstall TensorFlow](../../get_started/os_setup.md#pip-installation), the | |||
[build and reinstall TensorFlow](../../get_started/os_setup.md#create-the-pip-package-and-install), the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before making any of the {#anchor} changes on #660, this link originally pointed to this part of the file (which #660 maintained, using the GitHub style anchor tag), as opposed to this change which points to this part of the file several sections down. However, it looks like your change is probably going to a more relevant part of the page, as they will need to install from sources as opposed to 'easy-installing' from pip.
I'm thinking maybe this line should read
[build and reinstall TensorFlow](../../get_started/os_setup.md#installing-from-sources), the
to point to the very start of the "Installing from Sources" section as opposed to the very end of it.
Thoughts? Probably over thinking a one-line change to a doc file, but this piqued my curiosity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think create-the-pip-package-and-install is the right tag. Inside the
adding-an-op tutorial they'd already have a source install.
On Mon, Jan 4, 2016 at 9:48 PM Sam Abrahams notifications@github.com
wrote:
In tensorflow/g3doc/how_tos/adding_an_op/index.md
#683 (comment):@@ -107,7 +107,7 @@ REGISTER_KERNEL_BUILDER(Name("ZeroOut").Device(DEVICE_CPU), ZeroOutOp);
Once you -[build and reinstall TensorFlow](../../get_started/os_setup.md#pip-installation), the +[build and reinstall TensorFlow](../../get_started/os_setup.md#create-the-pip-package-and-install), the
Before making any of the {#anchor} changes on #660
#660, this link originally
pointed to this part of the file
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#pip-installation
(which #660 #660
maintained, using the GitHub style anchor tag), as opposed to this change
which points to this part of the file
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#create-th%0D%20e-pip-pa%0D%20ckage-and-install
several sections down. However, it looks like your change is probably going
to a more relevant part of the page, as they will need to install from
sources as opposed to 'easy-installing' from pip.I'm thinking maybe this line should read
build and reinstall TensorFlow, the
to point to the very start of the "Installing from Sources"
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md#installing-from-sources
section as opposed to the very end of it.Thoughts? Probably over thinking a one-line change to a doc file, but this
piqued my curiosity.—
Reply to this email directly or view it on GitHub
https://github.com/tensorflow/tensorflow/pull/683/files#r48814272.
Implementation of neural programmer.
1. Fix AMP tests 2. Added FusedMatMul to Allow List 3. Fix single threaded GEMM bug
I think these were missed by PR #660