Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore generated bazel_config while configure #7978

Closed
wants to merge 1 commit into from
Closed

Ignore generated bazel_config while configure #7978

wants to merge 1 commit into from

Conversation

Lewuathe
Copy link
Contributor

@Lewuathe Lewuathe commented Mar 1, 2017

./configure with default setting generates untracked files of bazel configs.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	tensorflow/core/platform/default/build_config.bzl-e
	tensorflow/core/platform/default/build_config_root.bzl-e

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@caisq caisq added the awaiting review Pull request awaiting review label Mar 6, 2017
@jart
Copy link
Contributor

jart commented Mar 7, 2017

Do you know what exactly is generating those files? I haven't seen them before.

@jart jart added the stat:awaiting response Status - Awaiting response from author label Mar 7, 2017
@jart jart mentioned this pull request Mar 8, 2017
Closed
@jart
Copy link
Contributor

jart commented Mar 8, 2017

I see what the problem is. It's a cross platform sed issue. I think the solution is to not have sed generate those files on Mac. Will send out PR soon.

jart added a commit to jart/tensorflow that referenced this pull request Mar 8, 2017
@jart
Make configure not create -e files on Mac
fea2d1f 
There is no cross platform way to use sed -i without backup files that
works in both GNU sed and Darwin sed. So a helper function has been
added to the configure script.

Closes tensorflow#7978
See tensorflow#8202
@jart jart mentioned this pull request Mar 8, 2017
Merged
@girving girving closed this in #8215 Mar 8, 2017
girving pushed a commit that referenced this pull request Mar 8, 2017
@jart @girving
Make configure not create -e files on Mac (#8215)
d53ac1c 
There is no cross platform way to use sed -i without backup files that
works in both GNU sed and Darwin sed. So a helper function has been
added to the configure script.

Closes #7978
See #8202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jart jart

Labels
awaiting review Pull request awaiting review cla: yes stat:awaiting response Status - Awaiting response from author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lewuathe @tensorflow-jenkins @jart @googlebot @caisq