Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Don’t require("crypto") in browsers. #1092

Merged
merged 1 commit into from Jun 10, 2018

Conversation

mbostock
Copy link
Contributor

@mbostock mbostock commented Jun 9, 2018

Same fix as tensorflow/tfjs#355.


This change is Reviewable

@dsmilkov
Copy link
Contributor

:lgtm_strong: Thanks! If crypto is ignored here, then users of tfjs-core (e.g. tfjs) won't have to explicitly ignore it, right?


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dsmilkov dsmilkov merged commit ca11033 into tensorflow:master Jun 10, 2018
@nsthorat
Copy link
Contributor

Awesome, thanks Mike! I think you're right, since we ignore it we don't have to do it for all dependencies of core.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants