adds error checking for tf.Buffer.get(outOfRangeLocation)

[bileschi]

Previously, given a buffer of size [2, 2], accessing [0, 2] and [1, 0] did the same thing, which can be surprising. This PR adds error checking.

Fixes tensorflow/tfjs#1304

---

This change is 

[dsmilkov]

Reviewable status: 0 of 1 approvals obtained (waiting on @bileschi and @dsmilkov)

---

src/tensor.ts, line 101 at r1 (raw file):

      locs = [0];
    }
    for (const i in locs) {

use for..of instead of for..in since the former is for arrays, and the latter is used for iterating through keys of an object, is slower, and doesn't guarantee order.

[bileschi]

Reviewable status: 0 of 1 approvals obtained

---

src/tensor.ts, line 101 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

use for..of instead of for..in since the former is for arrays, and the latter is used for iterating through keys of an object, is slower, and doesn't guarantee order.

done.

[dsmilkov]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! 1 of 1 approvals obtained