New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Adam optimizer #170

Merged
merged 3 commits into from Oct 6, 2017

Conversation

Projects
None yet
2 participants
@Lewuathe
Contributor

Lewuathe commented Oct 4, 2017

see: https://arxiv.org/abs/1412.6980

screen shot 2017-10-03 at 23 19 22


This change is Reviewable

@nsthorat

This comment has been minimized.

Collaborator

nsthorat commented Oct 6, 2017

:lgtm_strong:

Awesome - implementation looks right and I don't see any memory leaks. Great work :)


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@nsthorat nsthorat merged commit 61cdbe9 into tensorflow:master Oct 6, 2017

3 checks passed

cla/google All necessary CLAs are signed
code-review/reviewable 1/1 LGTMs
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment