Skip to content

Enable using a custom text dataset in LSTM CLI#350

Merged
pyu10055 merged 2 commits intotensorflow:masterfrom
c-w:lstm-custom-dataset
Aug 10, 2022
Merged

Enable using a custom text dataset in LSTM CLI#350
pyu10055 merged 2 commits intotensorflow:masterfrom
c-w:lstm-custom-dataset

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Jul 11, 2020

Currently the LSTM TensorflowJS example only supports a fixed set of preset text datasets. To enable users to easily experiment with their own datasets, this pull request enables passing arbitrary local text files to the training and generation scripts.

Additionally, I observed that the use of tf.loadModel in gen_node.js crashes since the method was renamed to tf.loadLayersModel in the tfjs 1.0 release. As such, this pull request also updates the model loading code to handle both the old and new method names.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@c-w
Copy link
Contributor Author

c-w commented Jul 21, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pyu10055 pyu10055 requested a review from caisq November 3, 2020 21:55
Copy link
Collaborator

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 1 approvals obtained (waiting on @caisq)

@pyu10055 pyu10055 removed the request for review from caisq August 10, 2022 02:40
@pyu10055 pyu10055 merged commit dfa0466 into tensorflow:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants