Enable using a custom text dataset in LSTM CLI#350
Merged
pyu10055 merged 2 commits intotensorflow:masterfrom Aug 10, 2022
c-w:lstm-custom-dataset
Merged
Enable using a custom text dataset in LSTM CLI#350pyu10055 merged 2 commits intotensorflow:masterfrom c-w:lstm-custom-dataset
pyu10055 merged 2 commits intotensorflow:masterfrom
c-w:lstm-custom-dataset
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
jenperson
approved these changes
Aug 10, 2022
jasonmayes
approved these changes
Aug 10, 2022
pyu10055
approved these changes
Aug 10, 2022
Collaborator
pyu10055
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 2 of 1 approvals obtained (waiting on @caisq)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the LSTM TensorflowJS example only supports a fixed set of preset text datasets. To enable users to easily experiment with their own datasets, this pull request enables passing arbitrary local text files to the training and generation scripts.
Additionally, I observed that the use of
tf.loadModelingen_node.jscrashes since the method was renamed totf.loadLayersModelin the tfjs 1.0 release. As such, this pull request also updates the model loading code to handle both the old and new method names.This change is