Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed person segmentation model to bodyPix #104

Merged
merged 6 commits into from Nov 18, 2018

Conversation

Projects
None yet
2 participants
@oveddan
Copy link
Contributor

commented Nov 13, 2018

fixes #890


This change is Reviewable

@nsthorat
Copy link
Collaborator

left a comment

Reviewable status: 0 of 1 approvals obtained (waiting on @oveddan)


body-pix/package.json, line 3 at r1 (raw file):

{
  "name": "@tensorflow-models/body-pix",
  "version": "0.0.4",

update this version just so we're not confused


body-pix/package.json, line 4 at r1 (raw file):

  "name": "@tensorflow-models/body-pix",
  "version": "0.0.4",
  "description": "Pretrained BodyPix model in tensorflow.js",

TensorFlow.js


body-pix/README.md, line 35 at r1 (raw file):

Each methodology has similar input parameters with different outputs.

### Loading a pre-trained PersonSegmenation Model

BoxyPix


body-pix/README.md, line 47 at r1 (raw file):

* **multiplier** - An optional number with values: `1.0`, `0.75`, or `0.50`, `0.25`. Defaults to `0.75`.   It is the float multiplier for the depth (number of channels) for all convolution operations. The value corresponds to a MobileNet architecture and checkpoint.  The larger the value, the larger the size of the layers, and more accurate the model at the cost of speed.  Set this to a smaller value to increase speed at the cost of accuracy.

**By default,** PersonSegmenation loads a model with a **`0.75`** multiplier.  This is recommended for computers with **mid-range/lower-end GPUS.**  A model with a **`1.00`** muliplier is recommended for computers with **powerful GPUS.** A model with a **`0.50`** or **`0.25`** architecture is recommended for **mobile.**

BodyPix, I would do a ctrl + f in this file


body-pix/demos/README.md, line 58 at r1 (raw file):

Link the local body-pix to the demos:
```sh
yalc link \@tensorflow-models/body-pix

is there supposed to be a slash at the beginning here?

@oveddan
Copy link
Contributor Author

left a comment

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @nsthorat)


body-pix/package.json, line 3 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

update this version just so we're not confused

Ok I set this to 0.0.1 - is that what you meant?


body-pix/README.md, line 35 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

BoxyPix

I mispelled the original...thats why this didn't show up in cntrl+f. replaced.


body-pix/README.md, line 47 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

BodyPix, I would do a ctrl + f in this file

Fixed (same issue as comment above).


body-pix/demos/README.md, line 58 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

is there supposed to be a slash at the beginning here?

No and that's probably what caused me some issues with this. I copied and pasted this from posenet. Fixed in both places.

fix
@nsthorat
Copy link
Collaborator

left a comment

Reviewed 23 of 31 files at r1, 10 of 10 files at r2.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @oveddan)


body-pix/package.json, line 3 at r1 (raw file):

Previously, oveddan (Dan Oved) wrote…

Ok I set this to 0.0.1 - is that what you meant?

yeah


body-pix/README.md, line 35 at r1 (raw file):

Previously, oveddan (Dan Oved) wrote…

I mispelled the original...thats why this didn't show up in cntrl+f. replaced.

Oops even I mispelled it :)


body-pix/README.md, line 47 at r1 (raw file):

Previously, oveddan (Dan Oved) wrote…

Fixed (same issue as comment above).

I see BodyBix here haha :)

@nsthorat
Copy link
Collaborator

left a comment

Nice work, will merge after BodyBix is changed lol

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @oveddan)

@oveddan
Copy link
Contributor Author

left a comment

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @oveddan and @nsthorat)


body-pix/README.md, line 47 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

I see BodyBix here haha :)

d'oh! fixed

@nsthorat
Copy link
Collaborator

left a comment

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@nsthorat nsthorat merged commit 19f1afc into tensorflow:master Nov 18, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.