Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[body-pix] - Readme improvements. #137

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@oveddan
Copy link
Contributor

commented Jan 28, 2019

  • Changed to have users pull jsdeliver latest version
  • Moved all readme images into images folder
  • Fixed some lingering invertMask code
  • Changed main gif.

This change is Reviewable

Readme improvements.
* Changed to have users pull jsdeliver latest version
* Fixed some lingering invertMask code
@dsmilkov
Copy link
Member

left a comment

Thanks for the improvements! Left couple small comments

Reviewed 8 of 8 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @oveddan)


body-pix/README.md, line 21 at r1 (raw file):

```html
  <script src="https://cdn.jsdelivr.net/npm/@tensorflow/tfjs@0.13.3"></script>
  <script src="https://cdn.jsdelivr.net/npm/@tensorflow-models/body-pix@latest"></script>

you don't need the "@latest" suffix, it's implicitly latest


body-pix/README.md, line 289 at r1 (raw file):

const personSegmentation = await net.estimatePersonSegmentation(imageElement);

// by setting maskBackground to false, the maskImage that is generated will be opaque where there is a person and opaque where there is a background.

it says opaque twice (for both the person and background)


body-pix/README.md, line 393 at r1 (raw file):

blurred onto a canvas.

An example of applying a [bokeh effect](https://www.nikonusa.com/en/learn-and-explore/a/tips-and-techniques/bokeh-for-beginners.html) can be seen by running the [demo](https://storage.googleapis.com/tfjs-models/demos/body-pix/camera.html):

replace by running the with in this (since users just have to click, there is no setup to run)

@dsmilkov
Copy link
Member

left a comment

Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 approvals obtained

@oveddan oveddan merged commit 96356a1 into tensorflow:master Jan 29, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.