Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing calculator tests #903

Merged
merged 3 commits into from Jan 19, 2022
Merged

Conversation

ahmedsabie
Copy link
Contributor

@ahmedsabie ahmedsabie commented Jan 14, 2022

This change is Reviewable

Copy link
Collaborator

@lina128 lina128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Ahmed! This is an example of product excellence, thank you!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @ahmedsabie)


hand-pose-detection/src/tfjs/detector.ts, line 262 at r1 (raw file):

        constants.MPHANDS_DETECTOR_NON_MAX_SUPPRESSION_CONFIGURATION
            .minSuppressionThreshold,
        'intersection-over-union');

Should it be part of the MPHANDS_DETECTOR_NON_MAX_SUPPRESSION_CONFIGURATION?

Code quote:

'intersection-over-union'

shared/calculators/convert_image_to_tensor.ts, line 81 at r1 (raw file):

        [outputTensorSize.height, outputTensorSize.width]);

    const imageShifted = outputTensorFloatRange ?

outputTensorFloatRange != null

Code quote:

outputTensorFloatRange

@lina128
Copy link
Collaborator

lina128 commented Jan 14, 2022

cc @pyu10055

Copy link
Contributor Author

@ahmedsabie ahmedsabie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @lina128)


hand-pose-detection/src/tfjs/detector.ts, line 262 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

Should it be part of the MPHANDS_DETECTOR_NON_MAX_SUPPRESSION_CONFIGURATION?

Done.


shared/calculators/convert_image_to_tensor.ts, line 81 at r1 (raw file):

Previously, lina128 (Na Li) wrote…

outputTensorFloatRange != null

Done.

@lina128 lina128 merged commit af59ff3 into tensorflow:master Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants