Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs and types #73

Merged
merged 3 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@tafsiri
Copy link
Member

commented May 1, 2019

Update the types used in various functions and a lot of the jsdoc comments (many doc comments move to interface definitions so they can be shared). The primary goal of this is to improve the rendering of vis docs on the website.

preview of effect:

before
Screen Shot 2019-05-01 at 11 23 06 AM

after
Screen Shot 2019-05-01 at 11 23 13 AM


This change is Reviewable

tafsiri added some commits May 1, 2019

@tafsiri tafsiri requested a review from nsthorat May 1, 2019

@nsthorat
Copy link
Collaborator

left a comment

Reviewed 12 of 12 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tafsiri tafsiri changed the title Improve doc types Improve docs and types May 1, 2019

@tafsiri tafsiri merged commit 7cb716d into master May 1, 2019

1 of 2 checks passed

Trigger: c3c31121-9c26-4fa0-af6f-aa373b83a2c3 Summary
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.