Skip to content

Commit

Permalink
Update iOS and OSX versions for testing (#8023)
Browse files Browse the repository at this point in the history
* update versions

* upd

* upd

* upd

* Update karma.conf.js
  • Loading branch information
Linchenn committed Oct 23, 2023
1 parent 349cf63 commit 00831de
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion e2e/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ module.exports = function(config) {
browser: 'safari',
browser_version: 'latest',
os: 'OS X',
os_version: 'High Sierra'
os_version: 'Mojave'
},
bs_ios_12: {
base: 'BrowserStack',
Expand Down
4 changes: 2 additions & 2 deletions e2e/script_tag_tests/tfjs-core-cpu/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,13 @@ module.exports = function(config) {
browser: 'safari',
browser_version: 'latest',
os: 'OS X',
os_version: 'High Sierra'
os_version: 'Mojave'
},
bs_ios_12: {
base: 'BrowserStack',
device: 'iPhone X',
os: 'iOS',
os_version: '11.0',
os_version: '12.3',
real_mobile: true
},
bs_android_10: {
Expand Down
4 changes: 2 additions & 2 deletions e2e/script_tag_tests/tfjs/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,13 @@ module.exports = function(config) {
browser: 'safari',
browser_version: 'latest',
os: 'OS X',
os_version: 'High Sierra'
os_version: 'Mojave'
},
bs_ios_12: {
base: 'BrowserStack',
device: 'iPhone X',
os: 'iOS',
os_version: '11.0',
os_version: '12.3',
real_mobile: true
},
bs_android_10: {
Expand Down
5 changes: 3 additions & 2 deletions tools/karma_template.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const CUSTOM_LAUNCHERS = {
browser: 'safari',
browser_version: 'latest',
os: 'OS X',
os_version: 'High Sierra'
os_version: 'Mojave'
},
bs_ios_12: {
base: 'BrowserStack',
Expand Down Expand Up @@ -173,7 +173,8 @@ module.exports = function(config) {
// This is necessary for non-flaky Safari tests. They usually pass just
// fine without it, but sometimes, Safari will fail to connect to Karma.
// If you want to remove this, prove that it's not flaky by running
// bazel test //tfjs-core/src:bs_safari_mac_from_pixels_worker_test --runs_per_test=100
// bazel test //tfjs-core/src:bs_safari_mac_from_pixels_worker_test
// --runs_per_test=100
extraConfig.hostname = 'bs-local.com';
}

Expand Down

0 comments on commit 00831de

Please sign in to comment.