[core] Do not fail if half float extension not found and we are not forcing half float rendering.

[annxingyuan]

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

---

This change is 

[pyu10055]

Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @pyu10055)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

          webgl_util.getExtensionOrThrow(this.gl, this.debug, TEXTURE_FLOAT);
      if (webgl_util.hasExtension(this.gl, TEXTURE_HALF_FLOAT)) {
        this.textureHalfFloatExtension = webgl_util.getExtensionOrThrow(

are there tests to ensure if the texturehalfFloatExtension is null, things still works?

[annxingyuan]

Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

are there tests to ensure if the texturehalfFloatExtension is null, things still works?

Half float textures are only used if we force F16 textures, hence the check in the else-if statement.

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan and @dsmilkov)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, annxingyuan (Ann Yuan) wrote…

Half float textures are only used if we force F16 textures, hence the check in the else-if statement.

In the tex_util.ts:218, it is checking the textureHalfFloatExtension != null, but gpgpu_context seems to default it to {}, can you verify if the value set there is correct?

[annxingyuan]

Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov and @pyu10055)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

In the tex_util.ts:218, it is checking the textureHalfFloatExtension != null, but gpgpu_context seems to default it to {}, can you verify if the value set there is correct?

gpgpu_context doesn't actually set textureHalfFloatExtension to {}, so if the extension is unavailable, textureHalfFloatExtension is undefined at tex_util.ts:218. In this case, textureTypeHalfFloat is set to null.

[dsmilkov]

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @pyu10055)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 80 at r1 (raw file):

      this.colorBufferFloatExtension = this.gl.getExtension(COLOR_BUFFER_FLOAT);
      this.colorBufferHalfFloatExtension =
          this.gl.getExtension(COLOR_BUFFER_HALF_FLOAT);

should you do a similar check for COLOB_BUFFER_HALF_FLOAT, that is error only in the case when float16 is forced?

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, annxingyuan (Ann Yuan) wrote…

gpgpu_context doesn't actually set textureHalfFloatExtension to {}, so if the extension is unavailable, textureHalfFloatExtension is undefined at tex_util.ts:218. In this case, textureTypeHalfFloat is set to null.

gpgpu_context.ts:38 is defaulting all of extensions to {}, did they get reset somewhere else?

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @annxingyuan)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 38 at r1 (raw file):

  gl: WebGLRenderingContext;
  textureFloatExtension: {};
  textureHalfFloatExtension: {};

FYI: here are the defaults.

[annxingyuan]

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

gpgpu_context.ts:38 is defaulting all of extensions to {}, did they get reset somewhere else?

I think that's not setting defaults - it's just a type annotation (hence the colon).

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 80 at r1 (raw file):

Previously, dsmilkov (Daniel Smilkov) wrote…

should you do a similar check for COLOB_BUFFER_HALF_FLOAT, that is error only in the case when float16 is forced?

Done

[pyu10055]

Reviewable status: complete! 1 of 1 approvals obtained (waiting on @annxingyuan)

---

tfjs-core/src/backends/webgl/gpgpu_context.ts, line 70 at r1 (raw file):

Previously, annxingyuan (Ann Yuan) wrote…

I think that's not setting defaults - it's just a type annotation (hence the colon).

you are right, need some glasses today.

[dsmilkov]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! 2 of 1 approvals obtained (waiting on @annxingyuan)