Skip to content

Conversation

@dsmilkov
Copy link
Contributor

@dsmilkov dsmilkov commented Dec 5, 2019

  • Add bodypix, posenet, mesh, and face detector to the benchmark page.
  • Make sure all the models are as fused as possible (using latest converter)
  • Fix mem leak during inference
  • Fix a small bug in model config
  • Add a dropdown with the backend type

This change is Reviewable

Copy link
Contributor

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 6 files at r5.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)


tfjs-core/benchmarks/index.html, line 350 at r5 (raw file):

      var gui = new dat.gui.GUI();

      await tf.ready();

why do you need both of these?

Copy link
Contributor Author

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @nsthorat)


tfjs-core/benchmarks/index.html, line 350 at r5 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

why do you need both of these?

don't need it now. removed.

@dsmilkov dsmilkov merged commit dccdfac into master Dec 5, 2019
@dsmilkov dsmilkov deleted the bench-facemesh branch December 5, 2019 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants