-
Notifications
You must be signed in to change notification settings - Fork 2k
[wasm] Add wasm and new models to the benchmark page #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…nto bench-facemesh
nsthorat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 6 files at r5.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @annxingyuan, @dsmilkov, and @nsthorat)
tfjs-core/benchmarks/index.html, line 350 at r5 (raw file):
var gui = new dat.gui.GUI(); await tf.ready();
why do you need both of these?
dsmilkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @annxingyuan and @nsthorat)
tfjs-core/benchmarks/index.html, line 350 at r5 (raw file):
Previously, nsthorat (Nikhil Thorat) wrote…
why do you need both of these?
don't need it now. removed.
This change is